OCPBUGS-59626: operator/v1helpers: add namespaced secret/configmap getters#2007
OCPBUGS-59626: operator/v1helpers: add namespaced secret/configmap getters#2007vrutkovs wants to merge 2 commits intoopenshift:masterfrom
Conversation
Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted key outside of target namespace. These new getters fall back to live client calls when a different namespace is being requested
Ensure that corruption of cluster-level cache doesn't affect static pod rollout
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-59626, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@vrutkovs: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-59626, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-59626. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Create new getters similar to CachedConfigMapGetter/CachedSecretGetter, but without a dependency on
a cluster-level informer. This allows the operator to continue functioning when etcd has a corrupted
key outside of target namespace. These new getters fall back to live client calls when a different
namespace is being requested.
Tested in openshift/cluster-kube-apiserver-operator#1916