-
Notifications
You must be signed in to change notification settings - Fork 251
NO-JIRA: operator/node-controller, guard-controller: parse the master node selector during construction #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: operator/node-controller, guard-controller: parse the master node selector during construction #1910
Conversation
|
@p0lyn0mial: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold for a proof pr |
|
/lgtm |
32df759 to
b99a02c
Compare
…rd and node controllers
b99a02c to
a0bab0e
Compare
|
/hold cancel |
|
@eggfoobar had to rebase the PR, PTAL. |
|
@p0lyn0mial: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
while reviewing #1882 I found that the master nodes selector is being parsed on each
syncfor some controllers.