Skip to content

CFE-882: add few test cases for external-certificate#1706

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
chiragkyal:fix-route-validation
Apr 3, 2024
Merged

CFE-882: add few test cases for external-certificate#1706
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
chiragkyal:fix-route-validation

Conversation

@chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Apr 3, 2024

Follow up : #1625

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2024 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references CFE-882 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Follow up : #1625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Miciah and frobware April 3, 2024 11:59
@chiragkyal
Copy link
Member Author

chiragkyal commented Apr 3, 2024

/assign @alebedev87 @Miciah

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chiragkyal chiragkyal mentioned this pull request Apr 3, 2024
Merged
@Miciah
Copy link
Contributor

Miciah commented Apr 3, 2024

/approve
/lgtm
Thanks!
/hold
in case @alebedev87 wants to review.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 3, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@alebedev87
Copy link
Contributor

alebedev87 commented Apr 3, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3064fcb into openshift:master Apr 3, 2024
@chiragkyal chiragkyal deleted the fix-route-validation branch April 3, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware Awaiting requested review from frobware

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@Miciah Miciah

@alebedev87 alebedev87

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chiragkyal @openshift-ci-robot @Miciah @alebedev87

Comments