Skip to content

Comments

APIServiceController: allow to pass informers for registering additional event handlers#1562

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:apiServicecontroller-informers
Aug 9, 2023
Merged

APIServiceController: allow to pass informers for registering additional event handlers#1562
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:apiServicecontroller-informers

Conversation

@ingvagabund
Copy link
Member

openshift/cluster-openshift-apiserver-operator#532 (comment)

APIServiceController can be passed a list of disabled/enabled APIs which might require additional resource to take into account when reconciling. In the case of openshift/cluster-openshift-apiserver-operator#532 new capabilities are taken into account when rendering a list of enabled/disabled API services.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit d7e7bec into openshift:master Aug 9, 2023
@ingvagabund ingvagabund deleted the apiServicecontroller-informers branch August 9, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants