Skip to content

Comments

add secret monitor#1554

Closed
deads2k wants to merge 9 commits intoopenshift:masterfrom
deads2k:secret-monitor
Closed

add secret monitor#1554
deads2k wants to merge 9 commits intoopenshift:masterfrom
deads2k:secret-monitor

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 13, 2023

/assign @thejasn

thejasn and others added 9 commits July 11, 2023 14:10
@thejasn
Add secret_manager for routes
80c9835
@thejasn
Update go.mod and vendor
fd4d7e0
@thejasn
Add internal monitor object
b03bfbd
@thejasn
Delete obsolete watch based managers
9c00d2e
@thejasn
Add secret monitor
0ac5b31
@thejasn
Update deps and vendor
88b71e4
@thejasn
Fix secret monitor ref count issue
ca26833 
Fixes one-to-many mapping of secret to multiple routes
@thejasn
Refactor to use a secret watcher abstraction
750c085 
Add SecretEventHandlerRegistration and SecretMonitor
interface as an abstraction for secret watchers and
consume the SecretMonitor via a Manager that interfaces
with routes
@deads2k
tweak secret manageR
b34d1d5
@deads2k deads2k mentioned this pull request Jul 13, 2023
Closed
@openshift-ci openshift-ci bot requested review from Miciah and candita July 13, 2023 22:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify b34d1d5 link true /test verify
ci/prow/unit b34d1d5 link true /test unit
ci/prow/verify-deps b34d1d5 link true /test verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thejasn
Copy link
Contributor

thejasn commented Aug 2, 2023

/close since changes have been pulled into #1518

@thejasn
Copy link
Contributor

thejasn commented Aug 2, 2023

/close

@openshift-ci openshift-ci bot closed this Aug 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@thejasn: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candita candita Awaiting requested review from candita

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@thejasn thejasn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deads2k @thejasn