Skip to content

Conversation

@LalatenduMohanty
Copy link
Member

@LalatenduMohanty LalatenduMohanty commented Mar 16, 2022

It will pick up the API changes required for capabilities

Generated with:

  $ go get github.com/openshift/api@d7c10d0b647e4c1a82c800556984e01f637577fd
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* vendor

using:

  $ go version
  go version go1.17.3 linux/amd64

This will pick up the new ClusterVersion capabilities stuff.

Signed-off-by: Lalatendu Mohanty lmohanty@redhat.com

@openshift-ci openshift-ci bot requested review from smarterclayton and sttts March 16, 2022 02:23
@wking
Copy link
Member

wking commented Mar 16, 2022

openshift/api@7e3ffb09acc is enough to get openshift/api#1106 for #1333. But there are a bunch of changes since then, and we might as well bring those in too:

$ git --no-pager log --oneline --first-parent 7e3ffb09acc..origin/master
d7c10d0b (HEAD -> master, wking/master, origin/release-4.12, origin/release-4.11, origin/master, origin/HEAD) Merge pull request #1126 from QiWang19/mirrorset
abf6417c [OCPCLOUD-1422] machine-api: azureprovider: add ultra disk support (#1119)
c21df433 Merge pull request #1134 from JoelSpeed/fix-optional-subnet
94bdffb4 Merge pull request #1112 from JoelSpeed/control-plane-machine-set
654ca07c Merge pull request #1131 from JoelSpeed/fix-partition-number-tag
5170e8de Merge pull request #1125 from honza/cbo-capability
7aa5824a Merge pull request #1123 from soltysh/bug2054693
24043075 Merge pull request #1107 from harche/node_object
354aa98a Merge pull request #1091 from JoelSpeed/mapi-aws-placement-groups
309b7ebb Merge pull request #1121 from bparees/console
271bd7e1 Merge pull request #1122 from gcs278/master
aa98df52 Merge pull request #1109 from bparees/compat
b632c5fc (origin/pr/1111) Merge pull request #1115 from bertinatto/god-help-us

It will pick up the API changes required for capabilities

    Generated with:

      $ go get github.com/openshift/api@d7c10d0b647e4c1a82c800556984e01f637577fd
      $ go mod tidy
      $ go mod vendor
      $ git add -A go.* vendor

    using:

      $ go version
      go version go1.17.3 linux/amd64

    This will pick up the new ClusterVersion capabilities stuff.

    Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Adjusted the unit tests to accomodate changes from below commits

openshift/api@de2aae0, openshift/api@3ad4150 and
openshift/api@e9e230b

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
Copy link
Member Author

openshift/api@7e3ffb09acc is enough to get openshift/api#1106 for #1333. But there are a bunch of changes since then, and we might as well bring those in too:

@wking Updated the PR to latest API commit

@wking
Copy link
Member

wking commented Mar 16, 2022

/retest

@LalatenduMohanty
Copy link
Member Author

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

@LalatenduMohanty: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@deads2k
Copy link
Contributor

deads2k commented Mar 17, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit edab248 into openshift:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants