Skip to content

add operator controller that can eliminate co-scheduled pods that should be separate#1330

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:kill-mal-scheduled-pod
Mar 25, 2022
Merged

add operator controller that can eliminate co-scheduled pods that should be separate#1330
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:kill-mal-scheduled-pod

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 14, 2022

This will mitigate the platform impact of the scheduler problems.

@deads2k
Copy link
Contributor Author

deads2k commented Mar 14, 2022

/hold

for proof

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2022
@openshift-ci openshift-ci bot requested review from soltysh and sttts March 14, 2022 17:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@deads2k deads2k force-pushed the kill-mal-scheduled-pod branch from 917680a to 129e11e Compare March 14, 2022 17:26
@deads2k deads2k force-pushed the kill-mal-scheduled-pod branch 2 times, most recently from f6536ca to eae28b4 Compare March 17, 2022 21:31
@deads2k deads2k force-pushed the kill-mal-scheduled-pod branch from eae28b4 to 53b4e03 Compare March 24, 2022 15:46
@deads2k
Copy link
Contributor Author

deads2k commented Mar 24, 2022

/hold cancel

@deads2k
Copy link
Contributor Author

deads2k commented Mar 24, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
oldestPod.Spec.NodeName,
oldestPod.Name,
)
err := c.kubeClient.CoreV1().Pods(oldestPod.Namespace).EvictV1(ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that we're using eviction API.

Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ravisantoshgudimetla, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a4cbaa7 into openshift:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants