image/registryclient: set insecure and return early in blobMirroredRepository #1096
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
soltysh
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
| } | ||
| if len(alternates) == 0 { | ||
| return attemptErr | ||
| } |
There was a problem hiding this comment.
This looks correct but now I want to see a unit test for it. This is the real loop we need to have unit tests on anyway.
| if err != nil { | ||
| return err | ||
| } | ||
| if len(alternates) == 0 { |
There was a problem hiding this comment.
@smarterclayton alternatively we could check for nil strategy in https://github.com/openshift/library-go/blob/master/pkg/image/registryclient/client_mirrored.go#L207 similarly to initialRepos or errorRepos
soltysh
changed the title
|
@dmage @ricardomaraschini @smarterclayton this should be ready for final review |
|
/assign @smarterclayton |
|
/retest |
|
/test unit |
1 similar comment
|
/test unit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
5 participants
This is followup to #1084 fixing:
insecureproperly forblobMirroredRepositorygolang.org/x/net/contextwith built-incontextpackage