Bug 1948311: UPSTREAM: 102606: Bring back "client-go: add retry logic for Watch and Stream" and fix test flake

[tkashem]

What type of PR is this?

/kind failing-test
/kind flake

What this PR does / why we need it:

We had to revert kubernetes#102107 due to flakes - the flaking tests can be found here https://storage.googleapis.com/k8s-gubernator/triage/index.html?pr=1&job=unit&test=k8s.io%2Fclient-go%2Frest

• This PR reverts the revert Revert "client-go: add retry logic for Watch and Stream" kubernetes/kubernetes#102581 to bring back client-go: add retry logic for Watch and Stream kubernetes/kubernetes#102107 - client-go: add retry logic for Watch and Stream
• It fixes the flake in test TestRequestWatchWithRetry

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

• The revert commit is clean and pristine
• The fix for test flake is in a separate commit so it is easier to review

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[openshift-ci]

@tkashem: This pull request references Bugzilla bug 1948311, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1948311: UPSTREAM: 102606: Bring back "client-go: add retry logic for Watch and Stream" and fix test flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@tkashem: the contents of this pull request could be automatically validated.

The following commits are valid:

• c66f9bc|UPSTREAM: 102581: Revert "client-go: add retry logic for Watch and Stream": the upstream PR kubernetes/kubernetes#102581 has merged
• e9c638a|UPSTREAM: 102606: Bring back "client-go: add retry logic for Watch and Stream" and fix test flake: the upstream PR kubernetes/kubernetes#102606 has merged

[tkashem]

/bugzilla refresh

[openshift-ci]

@tkashem: This pull request references Bugzilla bug 1948311, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sttts]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[tkashem]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@tkashem: An error was encountered searching for external tracker bugs for bug 1948311 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

could not parse external identifier "openshift/kubernetes/pull/669/" as pull: invalid pull identifier with 5 parts: "openshift/kubernetes/pull/669/"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1948311: UPSTREAM: 102606: Bring back "client-go: add retry logic for Watch and Stream" and fix test flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.