Bug 1958329: UPSTREAM: 97428: add more context to log after a request times out

[tkashem]

What type of PR is this?

/kind bug

What this PR does / why we need it:

when the timeout handler times out a request it writes 504 to the response and then spins up a go routine. The go routine waits for the inner handler to return the result.
This PR logs the result:

• with request verb and path
• with time elapsed since the timeout

log output:

E1221 13:28:44.939372   31341 timeout.go:130] a timeout response has already been sent - time elapsed since: 1.000324432s, GET "/version" result: net/http: abort Handler

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

New metric apiserver_request_post_timeout_total that tracks the post-timeout activity of a request after it had been timed out by the apiserver

[openshift-ci]

@tkashem: This pull request references Bugzilla bug 1958329, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 1958329: UPSTREAM: 97428: add more context to log after a request times out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@tkashem: the contents of this pull request could be automatically validated.

The following commits are valid:

• cbccffd|UPSTREAM: 100523: refactor rest.FinishRequest function: the upstream PR kubernetes/kubernetes#100523 has merged
• d7707e8|UPSTREAM: 97428: add more context to post timeout request activities: the upstream PR kubernetes/kubernetes#97428 has merged

[openshift-ci-robot]

@tkashem: the contents of this pull request could be automatically validated.

The following commits are valid:

• 0e6de31|UPSTREAM: 100523: refactor rest.FinishRequest function: the upstream PR kubernetes/kubernetes#100523 has merged
• 5a556a1|UPSTREAM: 97428: add more context to post timeout request activities: the upstream PR kubernetes/kubernetes#97428 has merged

[tkashem]

/retest

[tkashem]

/retest

[tkashem]

/retest

[sttts]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@tkashem: All pull requests linked via external trackers have merged:

• openshift/kubernetes#737

Bugzilla bug 1958329 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1958329: UPSTREAM: 97428: add more context to log after a request times out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.