Skip to content

WIP: BoundServiceAccountTokenVolume + service-ca.crt experiment#724

Closed
mtrmac wants to merge 2 commits intoopenshift:masterfrom
mtrmac:service-ca-secret-experiment
Closed

WIP: BoundServiceAccountTokenVolume + service-ca.crt experiment#724
mtrmac wants to merge 2 commits intoopenshift:masterfrom
mtrmac:service-ca-secret-experiment

Conversation

@mtrmac
Copy link

@mtrmac mtrmac commented Apr 30, 2021

I don’t really know what I’m doing, mostly curious to see how this fails.

Even if this works, it further cements down the use of long-term service account secrets. (I guess hypothetically we could continue to generate them, but only with the service-ca.crt component.)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Re-enable BoundServiceAccountTokenVolume ; to preserve the service-ca.crt file that was previously included in the mounted secret, just add a reference to the old secret in the created projected volume — the token controller generating the secrets with service-ca.crt included is still running and generating secrets in the right namespace.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Apr 30, 2021
@openshift-ci-robot
Copy link

@mtrmac: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtrmac
To complete the pull request process, please assign marun after the PR has been reviewed.
You can assign the PR to them by writing /assign @marun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtrmac
Copy link
Author

mtrmac commented Apr 30, 2021

/test all

@mtrmac mtrmac force-pushed the service-ca-secret-experiment branch from d6a2858 to 2be878a Compare April 30, 2021 19:28
@openshift-ci-robot
Copy link

@mtrmac: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@mtrmac
Copy link
Author

mtrmac commented Apr 30, 2021

/test all

@mtrmac mtrmac force-pushed the service-ca-secret-experiment branch from 2be878a to 8eb976a Compare April 30, 2021 20:04
@openshift-ci-robot
Copy link

@mtrmac: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@mtrmac
Copy link
Author

mtrmac commented Apr 30, 2021

/test all

@mtrmac mtrmac force-pushed the service-ca-secret-experiment branch from 8eb976a to 5639969 Compare April 30, 2021 23:34
@openshift-ci-robot
Copy link

@mtrmac: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@mtrmac
Copy link
Author

mtrmac commented Apr 30, 2021

/test all

@mtrmac mtrmac force-pushed the service-ca-secret-experiment branch from 5639969 to 3616d16 Compare May 1, 2021 12:57
@openshift-ci-robot
Copy link

@mtrmac: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@mtrmac
Copy link
Author

mtrmac commented May 1, 2021

/test all

mtrmac added 2 commits May 1, 2021 15:34
…e service-ca.crt

... with BoundServiceAccountTokenVolume .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…untTokenVolume by default"

This reverts commit d101b9e.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac force-pushed the service-ca-secret-experiment branch from 3616d16 to 68ba35e Compare May 1, 2021 13:35
@openshift-ci-robot
Copy link

@mtrmac: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@mtrmac
Copy link
Author

mtrmac commented May 1, 2021

/test all

@openshift-ci
Copy link

openshift-ci bot commented May 1, 2021

@mtrmac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 68ba35e link /test verify
ci/prow/e2e-aws-csi 68ba35e link /test e2e-aws-csi
ci/prow/e2e-gcp 68ba35e link /test e2e-gcp
ci/prow/k8s-e2e-gcp 68ba35e link /test k8s-e2e-gcp
ci/prow/e2e-aws-fips 68ba35e link /test e2e-aws-fips
ci/prow/e2e-gcp-upgrade 68ba35e link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtrmac mtrmac closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants