WIP: BoundServiceAccountTokenVolume + service-ca.crt experiment#724
WIP: BoundServiceAccountTokenVolume + service-ca.crt experiment#724mtrmac wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
@mtrmac: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
d6a2858 to
2be878a
Compare
|
@mtrmac: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test all |
2be878a to
8eb976a
Compare
|
@mtrmac: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test all |
8eb976a to
5639969
Compare
|
@mtrmac: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test all |
5639969 to
3616d16
Compare
|
@mtrmac: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test all |
…e service-ca.crt ... with BoundServiceAccountTokenVolume . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…untTokenVolume by default" This reverts commit d101b9e. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
3616d16 to
68ba35e
Compare
|
@mtrmac: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test all |
|
@mtrmac: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I don’t really know what I’m doing, mostly curious to see how this fails.
Even if this works, it further cements down the use of long-term service account secrets. (I guess hypothetically we could continue to generate them, but only with the
service-ca.crtcomponent.)What type of PR is this?
/kind bug
What this PR does / why we need it:
Re-enable BoundServiceAccountTokenVolume ; to preserve the
service-ca.crtfile that was previously included in the mounted secret, just add a reference to the old secret in the created projected volume — the token controller generating the secrets withservice-ca.crtincluded is still running and generating secrets in the right namespace.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: