Bug 1949050: UPSTREAM: 101337: Remove Limits from scheduling e2e balanced pod reso… #696
Conversation
…urces The purpose of the pod created by `createBalancedPodForNodes()` is to ensure that all nodes have equal resource requests (as seen by the scheduler). This prevents the default scheduling behavior (which attempts to balance resource requests) from interfering with e2e's which test other priorities/score plugins. Because the scheduler only worries about requests, specifying `Limits` in this pod is unnecessary. In fact, if the calculated "balancing" limit is too low, it can cause the balancing pod to never start due to OOMKill errors, leading to flakes and failures.
openshift-ci-robot
added
backports/unvalidated-commits
|
@damemi: This pull request references Bugzilla bug 1949050, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damemi: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
soltysh
removed
the
backports/unvalidated-commits
|
/retest |
1 similar comment
|
/retest |
|
/override ci/prow/e2e-agnostic-cmd |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damemi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-gcp-upgrade this improve e2e and upgrade job is failing on unrelated bug. |
|
@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-gcp-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damemi: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1949050 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
…urces
The purpose of the pod created by
createBalancedPodForNodes()is to ensurethat all nodes have equal resource requests (as seen by the scheduler). This
prevents the default scheduling behavior (which attempts to balance resource requests)
from interfering with e2e's which test other priorities/score plugins.
Because the scheduler only worries about requests, specifying
Limitsin this podis unnecessary. In fact, if the calculated "balancing" limit is too low, it can cause
the balancing pod to never start due to OOMKill errors, leading to flakes and failures.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: