Skip to content

UPSTREAM: <carry>: Disable CSI migration on OpenStack Cinder#651

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jsafrane:disable-cinder-migration
Apr 8, 2021
Merged

UPSTREAM: <carry>: Disable CSI migration on OpenStack Cinder#651
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jsafrane:disable-cinder-migration

Conversation

@jsafrane
Copy link

@jsafrane jsafrane commented Apr 7, 2021

This is a tech preview feature that must be explicitly enabled by setting FeatureGate CR (openshift/api#880).

For 4.8, we want AWS EBS and Cinder as tech preview for CSI migration. Both are Beta upstream, AWS EBS migration is off by default, Cinder is enabled by default (so we need to disable it in OCP in this PR).

This carry patch is to be carried until the CSI migration gets GA (~1.24?).

@openshift/storage

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 7, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2021

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@gnufied
Copy link
Member

gnufied commented Apr 7, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@jsafrane
UPSTREAM: <carry>: Disable CSI migration on OpenStack Cinder
1ae8a5f 
This is a tech preview feature that must be explicitly enabled by setting
FeatureGate CR.
@jsafrane jsafrane force-pushed the disable-cinder-migration branch from e62f0fa to 1ae8a5f Compare April 7, 2021 15:45
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2021

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

soltysh
soltysh approved these changes Apr 7, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2021
@soltysh soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 7, 2021
@openshift-bot
Copy link

openshift-bot commented Apr 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

openshift-bot commented Apr 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6d27558 into openshift:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@marun marun Awaiting requested review from marun

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jsafrane @openshift-ci-robot @gnufied @openshift-bot @soltysh @openshift-merge-robot