Bug 1945856: 99729:Only system-node-critical pods should be OOM Killed last by ravisantoshgudimetla · Pull Request #642 · openshift/kubernetes

ravisantoshgudimetla · 2021-03-31T12:39:22Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Backport of d201f2f which will go to master.

This will help in having appropriate priority classes for components like monitoring

cc @bparees @smarterclayton @rphillips

openshift-ci-robot · 2021-03-31T12:39:24Z

@ravisantoshgudimetla: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

UPSTREAM: 99729:Only system-node-critical pods should be OOM Killed last

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-31T12:39:30Z

@ravisantoshgudimetla: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

2b32649|UPSTREAM: 99729:Only system-node-critical pods should be OOM Killed last: does not specify an upstream backport in the commit message

bparees · 2021-03-31T12:42:32Z

cc @simonpasquier

ravisantoshgudimetla · 2021-03-31T12:48:52Z

cc @openshift/openshift-team-monitoring

ravisantoshgudimetla · 2021-03-31T14:59:58Z

/retest

ravisantoshgudimetla · 2021-03-31T18:13:37Z

/retest

ravisantoshgudimetla · 2021-04-01T23:31:57Z

/retest

ravisantoshgudimetla · 2021-04-09T12:17:59Z

/retest

openshift-ci-robot · 2021-04-12T12:34:09Z

@ravisantoshgudimetla: This pull request references Bugzilla bug 1945856, which is invalid:

expected dependent Bugzilla bug 1934516 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1945856: 99729:Only system-node-critical pods should be OOM Killed last

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ravisantoshgudimetla · 2021-04-12T12:35:07Z

/retest

ravisantoshgudimetla · 2021-04-12T12:35:36Z

/bugzilla refresh

openshift-ci-robot · 2021-04-12T12:35:41Z

@ravisantoshgudimetla: This pull request references Bugzilla bug 1945856, which is invalid:

expected dependent Bugzilla bug 1934516 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve

openshift-ci-robot · 2021-04-12T13:06:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/kubelet/DOWNSTREAM_OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-13T01:00:55Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-13T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1945856, which is invalid:

expected dependent Bugzilla bug 1934516 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-14T01:01:01Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-14T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1945856, which is invalid:

expected dependent Bugzilla bug 1934516 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-15T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-15T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1945856, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1934516 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1934516 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-15T14:46:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T16:11:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-16T02:35:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-16T02:47:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-16T10:50:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-16T12:21:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-16T13:08:40Z

@ravisantoshgudimetla: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-monitoring-operator#1103 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1945856 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1945856: 99729:Only system-node-critical pods should be OOM Killed last

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

UPSTREAM: 99729:Only system-node-critical pods should be OOM Killed last

2b32649

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 31, 2021

openshift-ci-robot requested review from rphillips and sjenning March 31, 2021 12:39

ravisantoshgudimetla mentioned this pull request Apr 1, 2021

Bug 1945856: Revert "Bug 1934516: [4.7]: jsonnet/prometheus.jsonnet: Apply system-cluster-critical class to cluster Prometheus " openshift/cluster-monitoring-operator#1103

Merged

ravisantoshgudimetla changed the title ~~UPSTREAM: 99729:Only system-node-critical pods should be OOM Killed last~~ Bug 1945856: 99729:Only system-node-critical pods should be OOM Killed last Apr 12, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2021

soltysh approved these changes Apr 12, 2021

View reviewed changes

soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 12, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021

openshift-ci-robot assigned soltysh Apr 12, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 15, 2021

openshift-ci-robot requested a review from juzhao April 15, 2021 01:01

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 15, 2021

openshift-merge-robot merged commit 7d0a2b2 into openshift:release-4.7 Apr 16, 2021

ravisantoshgudimetla deleted the release-4.7 branch April 16, 2021 13:19

Uh oh!

Conversation

ravisantoshgudimetla commented Mar 31, 2021

Uh oh!

openshift-ci-robot commented Mar 31, 2021

Uh oh!

openshift-ci-robot commented Mar 31, 2021

Uh oh!

bparees commented Mar 31, 2021

Uh oh!

ravisantoshgudimetla commented Mar 31, 2021

Uh oh!

ravisantoshgudimetla commented Mar 31, 2021

Uh oh!

ravisantoshgudimetla commented Mar 31, 2021

Uh oh!

ravisantoshgudimetla commented Apr 1, 2021

Uh oh!

ravisantoshgudimetla commented Apr 9, 2021

Uh oh!

openshift-ci-robot commented Apr 12, 2021

Uh oh!

ravisantoshgudimetla commented Apr 12, 2021

Uh oh!

ravisantoshgudimetla commented Apr 12, 2021

Uh oh!

openshift-ci-robot commented Apr 12, 2021

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 12, 2021

Uh oh!

openshift-bot commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

openshift-bot commented Apr 14, 2021

Uh oh!

openshift-ci-robot commented Apr 14, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-ci-robot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-ci-robot commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants