Skip to content

Bug 1942141: fixes cinder PV labelling #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
May 15, 2021
Merged

Bug 1942141: fixes cinder PV labelling #635

openshift-merge-robot merged 2 commits into from
May 15, 2021

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Mar 23, 2021

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Mar 23, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

@gnufied: This pull request references Bugzilla bug 1942141, which is invalid:

  • expected dependent Bugzilla bug 1941000 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1942141: fixes cinder PV labelling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 23, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

@gnufied: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Mar 23, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied gnufied force-pushed the revert-cinder-carry-patch branch from 5bd710d to ec9d501 Compare March 23, 2021 18:31
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

@gnufied: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@gnufied gnufied force-pushed the revert-cinder-carry-patch branch from ec9d501 to 30ebceb Compare March 23, 2021 19:07
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

@gnufied: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@gnufied
Copy link
Member Author

gnufied commented Mar 23, 2021

cc @openshift/sig-storage

@bertinatto
Copy link
Member

bertinatto commented Mar 24, 2021

/retest

@gnufied
Copy link
Member Author

gnufied commented Mar 24, 2021

/assign @Fedosin @jsafrane @mandre

@mandre
Copy link
Member

mandre commented Mar 24, 2021

/test e2e-openstack

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2021

@mandre: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-selfupgrade
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

Use /test all to run all jobs.

Details

In response to this:

/test e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Mar 29, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 29, 2021

@gnufied: This pull request references Bugzilla bug 1942141, which is invalid:

  • expected dependent Bugzilla bug 1941000 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Apr 27, 2021

Could you also include commit from #662 in this PR?

@mandre @gnufied
UPSTREAM: <carry>: Set informer for openstack
8f8420b 
Set informer for the openstack cloud provider to ensure it is properly
initialized when reading config from a secret.

Upstream 89885 was closed in favor of 96750.

Co-authored-by: Hemant Kumar <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2021

@gnufied: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@gnufied
Copy link
Member Author

gnufied commented Apr 27, 2021

@mandre done!

@gnufied
Copy link
Member Author

gnufied commented May 11, 2021

/retest
/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2021
@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2021

@gnufied: This pull request references Bugzilla bug 1942141, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1941000 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1941000 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huffmanca
Copy link

huffmanca commented May 11, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
soltysh
soltysh approved these changes May 12, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, huffmanca, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@soltysh soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 12, 2021
@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 14, 2021
@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented May 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ea91b60 into openshift:release-4.7 May 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2021

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 1942141 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1942141: fixes cinder PV labelling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marun marun Awaiting requested review from marun

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@jsafrane jsafrane

@huffmanca huffmanca

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.