Skip to content

Ensure multi-az test is run in the serial job#626

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
marun:multiaz-serial
Mar 22, 2021
Merged

Ensure multi-az test is run in the serial job#626
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
marun:multiaz-serial

Conversation

@marun
Copy link

@marun marun commented Mar 18, 2021 •
edited
Loading

Upstream PR: kubernetes#100378

This change is necessary to allow the disruptive quorum restore test to successfully pass conformance after restore.

/cc @smarterclayton @hexfusion

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 18, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2021

@marun: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2021

@marun: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@marun
Copy link
Author

marun commented Mar 18, 2021

/hold

Waiting for kubernetes#100378 to merge.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021
marun added 3 commits March 18, 2021 15:41
@marun
UPSTREAM: 100378: Tag Multi-AZ scheduling tests as serial
d1ecfdd 
As per mdame, we can't ensure that the cluster is actually balanced
if other tests are adding or deleting pods in parallel.
@marun
UPSTREAM: <carry>: Stop skipping multi-az test (skipped upstream)
9aff735
@marun
UPSTREAM: <drop>: Update test annotations
04967b5
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2021

@marun: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@marun
Copy link
Author

marun commented Mar 19, 2021

/hold cancel

The upstream PR is not likely to merge until 1.22, and we need this for 4.8.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021
soltysh
soltysh approved these changes Mar 19, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marun marun mentioned this pull request Mar 19, 2021
Merged
@openshift-bot
Copy link

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link

hexfusion commented Mar 20, 2021

LGTM
thanks @marun

@smarterclayton smarterclayton added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Mar 22, 2021
@openshift-bot
Copy link

openshift-bot commented Mar 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ed84e06 into openshift:master Mar 22, 2021
@damemi damemi mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hexfusion hexfusion Awaiting requested review from hexfusion

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marun @openshift-ci-robot @openshift-bot @hexfusion @soltysh @smarterclayton @openshift-merge-robot