Skip to content

Bug 1919737: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danwinship merged 1 commit into from
Feb 18, 2021
Merged

Bug 1919737: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/proxy/iptables/proxier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,20 @@ func (proxier *Proxier) syncProxyRules() {
hasEndpoints = len(allEndpoints) > 0
}

// Prefer local endpoint for the DNS service.
// Fixes <https://bugzilla.redhat.com/show_bug.cgi?id=1919737>.
// TODO: Delete this if-block once internal traffic policy is
// implemented and the DNS operator is updated to use it.
if svcNameString == "openshift-dns/dns-default:dns" {
for _, ep := range allEndpoints {
if ep.GetIsLocal() {
klog.V(4).Infof("Found a local endpoint %q for service %q; preferring the local endpoint and ignoring %d other endpoints", ep.String(), svcNameString, len(allEndpoints) - 1)
allEndpoints = []proxy.Endpoint{ep}
break
}
}
}

svcChain := svcInfo.servicePortChainName
if hasEndpoints {
// Create the per-service chain, retaining counters if possible.
Expand Down