Skip to content

Bug 1945091: Don't force-disable IPv6, dual-stack, and SCTP tests#565

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:network-config-test-skips
May 19, 2021
Merged

Bug 1945091: Don't force-disable IPv6, dual-stack, and SCTP tests#565
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:network-config-test-skips

Conversation

@danwinship
Copy link

@danwinship danwinship commented Feb 10, 2021

The openshift/kubernetes side of openshift/origin#25818. This needs to merge after that does, since these tests still need to be disabled in most configurations.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 10, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2021

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danwinship danwinship mentioned this pull request Feb 10, 2021
Merged
@danwinship danwinship force-pushed the network-config-test-skips branch from e1dc6af to b39e328 Compare April 10, 2021 16:53
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2021

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship danwinship force-pushed the network-config-test-skips branch from b39e328 to edcf106 Compare April 28, 2021 13:10
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 28, 2021

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship danwinship mentioned this pull request Apr 28, 2021
Closed
@danwinship
Copy link
Author

danwinship commented Apr 30, 2021

/retest
/assign @marun

Tried out openshift/origin#26111 on top of the current origin 1.21 rebase PR, and lots of stuff failed just like in the real rebase PR, but you can see in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26111/pull-ci-openshift-origin-master-e2e-gcp/1387400869405790208 that the [Feature:Networking-IPv4] tests ran, but the [Feature:Networking-IPv6], [Feature:IPv6DualStack], and [Feature:SCTPConnectivity] tests did not. So it's safe to merge this now

@danwinship danwinship changed the title Don't force-disable IPv6, dual-stack, and SCTP tests Bug 1945091: Don't force-disable IPv6, dual-stack, and SCTP tests Apr 30, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2021

@danwinship: This pull request references Bugzilla bug 1945091, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1945091: Don't force-disable IPv6, dual-stack, and SCTP tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 30, 2021
@danwinship
Copy link
Author

danwinship commented Apr 30, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 30, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2021

@danwinship: This pull request references Bugzilla bug 1945091, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 30, 2021
@knobunc
Copy link

knobunc commented May 7, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@danwinship danwinship force-pushed the network-config-test-skips branch from edcf106 to 0232c3e Compare May 11, 2021 20:20
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 11, 2021

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship
UPSTREAM: <carry>: Don't force-disable IPv6, dual-stack, and SCTP tests
dcfa846 
Instead, openshift-tests will enable or disable them depending on
cluster configuration.
@danwinship danwinship force-pushed the network-config-test-skips branch from 0232c3e to dcfa846 Compare May 12, 2021 13:14
soltysh
soltysh approved these changes May 17, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@soltysh soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 17, 2021
@danwinship
Copy link
Author

danwinship commented May 17, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented May 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Author

danwinship commented May 17, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented May 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link

openshift-bot commented May 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2df5a14 into openshift:master May 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2021

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1945091 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1945091: Don't force-disable IPv6, dual-stack, and SCTP tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the network-config-test-skips branch November 19, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marun marun

@soltysh soltysh

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danwinship @openshift-ci-robot @knobunc @openshift-bot @soltysh @marun @openshift-merge-robot