Bug 1916489: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes#526
Conversation
|
@damemi: This pull request references Bugzilla bug 1916489, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@damemi: This pull request references Bugzilla bug 1916489, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@damemi Failures appears to point to a problem with what is proposed in this PR? |
|
Interesting failure because it's not happening in the upstream PR, but it seems like the nodeName I'm trying to set for the selector is nil. There was also some upstream questions about how this affects other runtimes. I'm assuming openshift is based on cri-o, but I need to talk to containers folks about that because it's out of my expertise |
…eBalancedPodForNodes
4d4f6e6 to
0e4d1ec
Compare
|
@damemi: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
0e4d1ec to
110e007
Compare
|
@damemi: the contents of this pull request could be automatically validated. The following commits are valid: |
|
@damemi: This pull request references Bugzilla bug 1916489, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@damemi: This pull request references Bugzilla bug 1916489, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@damemi: All pull requests linked via external trackers have merged: Bugzilla bug 1916489 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@damemi: All pull requests linked via external trackers have merged: Bugzilla bug 1916489 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pulls changes from kubernetes#98073
/hold
for upstream review