Skip to content

Bug 1916489: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes#526

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
damemi:openshift-fix-priority-balancedpods
Feb 22, 2021
Merged

Bug 1916489: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes#526
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
damemi:openshift-fix-priority-balancedpods

Conversation

@damemi
Copy link

@damemi damemi commented Jan 14, 2021

Pulls changes from kubernetes#98073
/hold
for upstream review

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@damemi damemi changed the title UPSTREAM: 98073: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes Bug 1916489: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes Jan 14, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 14, 2021
@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1916489, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1916489: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2021
@damemi
Copy link
Author

damemi commented Jan 14, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2021
@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1916489, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2021
@damemi
Copy link
Author

damemi commented Jan 14, 2021

/retest

3 similar comments
@damemi
Copy link
Author

damemi commented Jan 15, 2021

/retest

@damemi
Copy link
Author

damemi commented Jan 15, 2021

/retest

@marun
Copy link

marun commented Jan 15, 2021

/retest

@marun
Copy link

marun commented Jan 15, 2021

@damemi Failures appears to point to a problem with what is proposed in this PR?

@damemi
Copy link
Author

damemi commented Jan 25, 2021

Interesting failure because it's not happening in the upstream PR, but it seems like the nodeName I'm trying to set for the selector is nil.

There was also some upstream questions about how this affects other runtimes. I'm assuming openshift is based on cri-o, but I need to talk to containers folks about that because it's out of my expertise

@damemi damemi force-pushed the openshift-fix-priority-balancedpods branch from 4d4f6e6 to 0e4d1ec Compare February 19, 2021 15:18
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Feb 19, 2021
@openshift-ci-robot
Copy link

@damemi: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@damemi damemi force-pushed the openshift-fix-priority-balancedpods branch from 0e4d1ec to 110e007 Compare February 19, 2021 15:18
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 19, 2021
@openshift-ci-robot
Copy link

@damemi: the contents of this pull request could be automatically validated.

The following commits are valid:

Copy link
Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/bugzilla refresh
/cc @soltysh
this has merged upstream now, commit picked and rebased here. ready for review

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Feb 19, 2021
@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1916489, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/hold cancel
/bugzilla refresh
/cc @soltysh
this has merged upstream now, commit picked and rebased here. ready for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 19, 2021
@damemi
Copy link
Author

damemi commented Feb 19, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

@damemi: This pull request references Bugzilla bug 1916489, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 19, 2021
@damemi
Copy link
Author

damemi commented Feb 19, 2021

/retest

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4705571 into openshift:master Feb 22, 2021
@openshift-ci-robot
Copy link

@damemi: All pull requests linked via external trackers have merged:

Bugzilla bug 1916489 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1916489: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damemi
Copy link
Author

damemi commented May 17, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@damemi: All pull requests linked via external trackers have merged:

Bugzilla bug 1916489 has been moved to the MODIFIED state.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants