Skip to content

WIP: UPSTREAM 92968: Add Terminating Condition to EndpointSlice#431

Closed
Miciah wants to merge 7 commits intoopenshift:masterfrom
Miciah:UPSTREAM-92968-endpointslice-termination
Closed

WIP: UPSTREAM 92968: Add Terminating Condition to EndpointSlice#431
Miciah wants to merge 7 commits intoopenshift:masterfrom
Miciah:UPSTREAM-92968-endpointslice-termination

Conversation

@Miciah
Copy link

@Miciah Miciah commented Oct 28, 2020

Testing WIP upstream changes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 28, 2020
@Miciah Miciah force-pushed the UPSTREAM-92968-endpointslice-termination branch 4 times, most recently from 0cfc8cf to 374c517 Compare November 24, 2020 18:14
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
…ting'

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
…minating'

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
…bles

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
…erminating endpoints

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@Miciah Miciah force-pushed the UPSTREAM-92968-endpointslice-termination branch from 374c517 to d81a7ee Compare November 25, 2020 01:04
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 25, 2020

@Miciah: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-commits d81a7ee link /test verify-commits
ci/prow/verify d81a7ee link /test verify
ci/prow/e2e-gcp d81a7ee link /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 25, 2021
@Miciah
Copy link
Author

Miciah commented Mar 31, 2021

/close
Superseded by #607 and openshift/sdn#271.

@openshift-ci-robot
Copy link

@Miciah: Closed this PR.

Details

In response to this:

/close
Superseded by #607 and openshift/sdn#271.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants