-
Notifications
You must be signed in to change notification settings - Fork 126
OCPBUGS-61381: Enable DRA related tests from OCP-4.21 #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sairameshv: This pull request references Jira Issue OCPBUGS-61381, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sairameshv: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sairameshv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I would like to monitor the TP enabled jobs i.e. |
|
@sairameshv: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@sairameshv: This pull request references Jira Issue OCPBUGS-61381, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sairameshv: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/cc @tkashem |
…gate - Fixes OCPBUGS-61381, enables DRA related tests from OCP-4.21 - DRA has been graduated to GA in upstream from K8s-1.34 i.e OCP-4.21 - These tests need to be enabled to get some signal so that the featuregate can be enabled for the Default cluster types in o/api - Disabling the tests that run on the DRA beta APIs as we support the GA APIs only Signed-off-by: Sai Ramesh Vanka <[email protected]>
|
@sairameshv: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
| "[sig-node] ImageCredentialProvider [Feature:KubeletCredentialProviders] should be able to create pod with image credentials fetched from external credential provider", | ||
| }, | ||
| // tests for beta APIs that are not enabled | ||
| "DisabledResourceBetaAPI": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jacobsee , @bertinatto
I know you have been working on the rebase and so the disabling of DRA beta related tests from your commit of the 1.34 rebase PR
Do you think this change of keeping the beta tests under a separate key "DisabledResourceBetaAPI" makes sense? If so, do you want to pick this commit as part of the rebase PR?
|
@sairameshv: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing the PR as this is already addressed as part of the 1.34 rebase PR's commit |
|
@sairameshv: This pull request references Jira Issue OCPBUGS-61381. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Enables the DRA related tests to be run for all the techpreview jobs
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is to get some signal from sippy so that the featuregate can be removed/enable for the all/default cluster types
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: