OCPBUGS-43994: UPSTREAM: <carry>: kube-apiserver: wire through isTerminating into handler chain

[tchap]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This reverts commit 6d6b285

It removes isTerminating check from logging HTTP requests.
This check has actually been untested and broken. Reverting the commit
does not actually change any behaviour, it only removes duplicate HTTP
request logs, which are actually an issue.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

[openshift-ci-robot]

@tchap: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 831dc34|Revert "UPSTREAM: : kube-apiserver: wire through isTerminating into handler chain": does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[p0lyn0mial]

lgtm

the original pr is very old (found in 4.15) and never worked. by removing the commit we won't change any behaviour. the code will work as before. i am ok with that.

@tchap we need to change the commit message.
@tchap please verify it manually.

[p0lyn0mial]

@bertinatto once this pr merges we should also remove the original commit from the current rebase PR. we will let you know.

[openshift-ci-robot]

@tchap: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 863444a|UPSTREAM: : kas: Remove isTerminating flag: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[tchap]

we need to change the commit message.

@p0lyn0mial How is it supposed to look like? Sorry, I am new to this.

[bertinatto]

we need to change the commit message.

@p0lyn0mial How is it supposed to look like? Sorry, I am new to this.

Please use the same title as 6d6b285, including the <carry> rather than <drop>.

Edit: oh, please keep the current description, where you say it reverts 6d6b285.

[p0lyn0mial]

Please use the same title as 6d6b285, including the rather than .

Edit: oh, please keep the current description, where you say it reverts 6d6b285.

ok, thanks, so we change the tile to match the original PR but keep the description where we say it reverts the original commit.

[openshift-ci-robot]

@tchap: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• f6d00c9|UPSTREAM: : kube-apiserver: wire through isTerminating into handler chain: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[tchap]

Please use the same title as 6d6b285

Renamed.

[p0lyn0mial]

@tchap have you verified it solves the duplicate entries issue ?

[tchap]

have you verified it solves the duplicate entries issue ?

@p0lyn0mial I am on it, will let you know.

[p0lyn0mial]

/lgtm

/hold
for manual check #2477 (comment)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

/retest-required

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-43994, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This reverts commit 6d6b285

It removes isTerminating check from logging HTTP requests.
This check has actually been untested and broken. Reverting the commit
does not actually change any behaviour, it only removes duplicate HTTP
request logs, which are actually an issue.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

I tested this manully

/unhold

[p0lyn0mial]

/retest-required
/hold cancel
/verified by @tchap

[openshift-ci-robot]

@p0lyn0mial: This PR has been marked as verified by @tchap.

In response to this:

/retest-required
/hold cancel
/verified by @tchap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[p0lyn0mial]

@bertinatto @jacobsee please don't forget to remove the patch from the current rebase PR.

[openshift-ci]

@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-csi	f6d00c9	link	false	/test e2e-aws-csi
ci/prow/e2e-aws-ovn-techpreview	f6d00c9	link	false	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-techpreview-serial	f6d00c9	link	false	/test e2e-aws-ovn-techpreview-serial
ci/prow/k8s-e2e-aws-ovn-serial	f6d00c9	link	false	/test k8s-e2e-aws-ovn-serial
ci/prow/okd-scos-e2e-aws-ovn	f6d00c9	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@tchap: Jira Issue OCPBUGS-43994: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/kubernetes#2451 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-43994 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This reverts commit 6d6b285

It removes isTerminating check from logging HTTP requests.
This check has actually been untested and broken. Reverting the commit
does not actually change any behaviour, it only removes duplicate HTTP
request logs, which are actually an issue.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.