Skip to content

OCPBUGS-58313: apiserver library go bump#2457

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jubittajohn:ocpbugs-58313-update-apiserver-library-go
Sep 12, 2025
Merged

OCPBUGS-58313: apiserver library go bump#2457
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jubittajohn:ocpbugs-58313-update-apiserver-library-go

Conversation

@jubittajohn
Copy link

What this PR does / why we need it:

  • Bumps apiserver-library-go
  • Adds missing safe sysctls to list of SafeSysctlAllowlist [As part of Kubernetes v1.32, several sysctls [1] have been added to the SafeSysctlAllowlist. However, that list has not yet been updated in OCP]

Which issue(s) this PR fixes:

Fixes # OCPBUGS-58313

Special notes for your reviewer:

Bumping the changes introduced in the PR: openshift/apiserver-library-go#148

Does this PR introduce a user-facing change?

Yes
The list of safe sysctls available changes with this PR.

…ysctls

Signed-off-by: jubittajohn <jujohn@redhat.com>
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2025
@openshift-ci-robot
Copy link

@jubittajohn: This pull request references Jira Issue OCPBUGS-58313, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

  • Bumps apiserver-library-go
  • Adds missing safe sysctls to list of SafeSysctlAllowlist [As part of Kubernetes v1.32, several sysctls [1] have been added to the SafeSysctlAllowlist. However, that list has not yet been updated in OCP]

Which issue(s) this PR fixes:

Fixes # OCPBUGS-58313

Special notes for your reviewer:

Bumping the changes introduced in the PR: openshift/apiserver-library-go#148

Does this PR introduce a user-facing change?

Yes
The list of safe sysctls available changes with this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@jubittajohn: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 11, 2025
@jubittajohn
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2025
@openshift-ci-robot
Copy link

@jubittajohn: This pull request references Jira Issue OCPBUGS-58313, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia September 11, 2025 16:15
@jubittajohn
Copy link
Author

/test unit

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit c3074dc matches the current tip of openshift/apiserver-library-go

/remove-label backports/unvalidated-commits
/lgtm

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 11, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@jubittajohn
Copy link
Author

/test e2e-aws-ovn-runc

@jubittajohn
Copy link
Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2025

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xingxingxia
Copy link

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 12, 2025
@openshift-ci-robot
Copy link

@xingxingxia: This PR has been marked as verified by @xingxingxia,https://issues.redhat.com/browse/OCPBUGS-58313?focusedId=28044589&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28044589.

Details

In response to this:

Pre-merge verified with cluster-bot build. Details see below link:
/verified by @xingxingxia,https://issues.redhat.com/browse/OCPBUGS-58313?focusedId=28044589&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28044589

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 679fad5 into openshift:master Sep 12, 2025
25 checks passed
@openshift-ci-robot
Copy link

@jubittajohn: Jira Issue OCPBUGS-58313: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-58313 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:

  • Bumps apiserver-library-go
  • Adds missing safe sysctls to list of SafeSysctlAllowlist [As part of Kubernetes v1.32, several sysctls [1] have been added to the SafeSysctlAllowlist. However, that list has not yet been updated in OCP]

Which issue(s) this PR fixes:

Fixes # OCPBUGS-58313

Special notes for your reviewer:

Bumping the changes introduced in the PR: openshift/apiserver-library-go#148

Does this PR introduce a user-facing change?

Yes
The list of safe sysctls available changes with this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jubittajohn jubittajohn deleted the ocpbugs-58313-update-apiserver-library-go branch September 19, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants