-
Notifications
You must be signed in to change notification settings - Fork 127
[release-4.19] OCPBUGS-61488: UPSTREAM: <carry>: backporting fix for concurrent map iteration and write #2456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d write Improve audit context handling by encapsulating event data and operations behind a structured API. Make the Audit system more robust in concurrent environments by properly isolating mutable state. The cleaner API simplifies interaction with audit events, improving maintainability. Encapsulation reduces bugs by preventing direct manipulation of audit events. Signed-off-by: Davanum Srinivas <[email protected]> Co-Authored-By: Jordan Liggitt <[email protected]> Co-Authored-By: sxllwx <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]> Co-Authored-By: Jordan Liggitt <[email protected]> Set event level during context init Signed-off-by: Davanum Srinivas <[email protected]>
… going to use it Merge pull request kubernetes#131725 from dims/avoid-encoding-in-log-response-object-when-we-dont-need-it
When backporting some changes from upstream's master branch a unit test ended up being broken. The code covered by this test does not seem to exist upstream, neither the test file. The code this commit fixes was introduced by 57c60d8 and we should squash this one with it once the time for rebasing arrives. Even though 57c60d8 description reads "UPSTREAM: 115328: annotate early and late requests" the upstream PR 115328 was closed without merging.
|
@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-61347 has been cloned as Jira Issue OCPBUGS-61488. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61488, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@ricardomaraschini: This pull request references Jira Issue OCPBUGS-61488, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, openshift-cherrypick-robot, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label backport-risk-assessed |
|
/verified by @wangke19 |
|
@wangke19: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
335be3a
into
openshift:release-4.19
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-61488 Jira Issue OCPBUGS-61488 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
|
Fix included in accepted release 4.19.0-0.nightly-2025-09-13-202922 |
|
/cherry-pick release-4.18 |
|
@ricardomaraschini: #2456 failed to apply on top of branch "release-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[release-4.18] OCPBUGS-61773: UPSTREAM: <carry>: backporting fix for concurrent map iteration and write #2456
…2475-to-release-4.17 [release-4.17] OCPBUGS-63460: UPSTREAM: <carry>: backporting fix for concurrent map iteration and write #2456
This is an automated cherry-pick of #2450
/assign ricardomaraschini