Skip to content

Conversation

@sdodson
Copy link
Member

@sdodson sdodson commented Aug 21, 2025

Reverts #2333

This broke 4.18 builds because we have upgrade jobs from 4.17 to 4.18. We could special case that but we're just backporting changes to MCO to switch to v1 in 4.17 as well. However those won't be effective for upgrades jobs until the next 4.17.z is promoted into the candidate channels.

…onregistration.k8s.io/v1beta1 as deprecated."
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2025
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-57488, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-55937 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #2333

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@sdodson: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from bertinatto and jerpeter1 August 21, 2025 19:02
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-57488, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-55937 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Reverts #2333

This broke 4.18 builds because we have upgrade jobs from 4.17 to 4.18. We could special case that but we're just backporting changes to MCO to switch to v1 in 4.17 as well. However those won't be effective for upgrades jobs until the next 4.17.z is promoted into the candidate channels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2025
@sdodson sdodson removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson changed the title Revert "[release-4.18] OCPBUGS-57488: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated." UPSTREAM: <revert><carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated." Aug 21, 2025
@openshift-ci-robot
Copy link

@sdodson: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Reverts #2333

This broke 4.18 builds because we have upgrade jobs from 4.17 to 4.18. We could special case that but we're just backporting changes to MCO to switch to v1 in 4.17 as well. However those won't be effective for upgrades jobs until the next 4.17.z is promoted into the candidate channels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2025
@sdodson sdodson changed the title UPSTREAM: <revert><carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated." UPSTREAM: revert<carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated." Aug 21, 2025
@sdodson
Copy link
Member Author

sdodson commented Aug 21, 2025

/test verify-commits

@sdodson
Copy link
Member Author

sdodson commented Aug 21, 2025

/override ci/prow/verify-commits ci/prow/okd-scos-images

@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/okd-scos-images, ci/prow/verify-commits

Details

In response to this:

/override ci/prow/verify-commits ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
Copy link
Member Author

sdodson commented Aug 21, 2025

/skip

@sdodson
Copy link
Member Author

sdodson commented Aug 21, 2025

/test e2e-aws-ovn-fips

@sdodson sdodson added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2025

@sdodson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 6839248 link true /test verify-commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 971b931 into release-4.18 Aug 22, 2025
22 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.18.0-202508220233.p0.g971b931.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.18.0-202508220233.p0.g971b931.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.18.0-202508220233.p0.g971b931.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.18.0-202508220233.p0.g971b931.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants