Skip to content

Conversation

@smg247
Copy link
Member

@smg247 smg247 commented Jul 30, 2025

This was done in #2247, but only using the external platform. I am not entirely sure if that is still necessary, but it is safer to also add this for the none platform as that is what MicroShift reports itself as. This is the only test that is failing in the microshift job run, after merging #2331

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 30, 2025
@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from benluddy and bertinatto July 30, 2025 10:40
@smg247 smg247 changed the title UPSTREAM: <carry>: skip specific LoadBalancer test for "none" platform Skip specific LoadBalancer test for "none" platform Jul 30, 2025
Copy link

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
Hold in case you want more reviews, from MicroShift's POV this is correct.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025
@stbenjam
Copy link
Member

/hold cancel
/lgtm
/remove-label backports/unvalidated-commits

@openshift-ci openshift-ci bot removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 30, 2025
Copy link

@p0lyn0mial p0lyn0mial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one question.

@p0lyn0mial
Copy link

FYI ci/prow/configmap-scale is perma failing, potential fix in openshift/release#67662

@smg247
Copy link
Member Author

smg247 commented Jul 30, 2025

/override ci/prow/configmap-scale

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@smg247: Overrode contexts on behalf of smg247: ci/prow/configmap-scale

Details

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@p0lyn0mial
Copy link

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, pacevedom, smg247, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@smg247 smg247 changed the title Skip specific LoadBalancer test for "none" platform OCPBUGS-59956: Skip specific LoadBalancer test for "none" platform Jul 30, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 30, 2025
@openshift-ci-robot
Copy link

@smg247: This pull request references Jira Issue OCPBUGS-59956, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This was done in #2247, but only using the external platform. I am not entirely sure if that is still necessary, but it is safer to also add this for the none platform as that is what MicroShift reports itself as. This is the only test that is failing in the microshift job run, after merging #2331

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@smg247 smg247 changed the title OCPBUGS-59956: Skip specific LoadBalancer test for "none" platform TRT-2068: Skip specific LoadBalancer test for "none" platform Jul 30, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 30, 2025

@smg247: This pull request references TRT-2068 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This was done in #2247, but only using the external platform. I am not entirely sure if that is still necessary, but it is safer to also add this for the none platform as that is what MicroShift reports itself as. This is the only test that is failing in the microshift job run, after merging #2331

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c42ba29 and 2 for PR HEAD e6d8189 in total

@smg247
Copy link
Member Author

smg247 commented Jul 30, 2025

/override ci/prow/configmap-scale

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@smg247: Overrode contexts on behalf of smg247: ci/prow/configmap-scale

Details

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smg247
Copy link
Member Author

smg247 commented Jul 30, 2025

/label backports/vaidated-commits

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@smg247: The label(s) /label backports/vaidated-commits cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, backports/unvalidated-commits, backports/validated-commits, bugzilla/invalid-bug, bugzilla/valid-bug, cherry-pick-approved, jira/invalid-bug, jira/valid-bug, jira/valid-reference, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label backports/vaidated-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smg247
Copy link
Member Author

smg247 commented Jul 30, 2025

/label backports/validated-commits

@openshift-ci openshift-ci bot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Jul 30, 2025
@smg247
Copy link
Member Author

smg247 commented Jul 30, 2025

/override ci/prow/configmap-scale

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@smg247: Overrode contexts on behalf of smg247: ci/prow/configmap-scale

Details

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@smg247: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws e6d8189 link false /test e2e-aws
ci/prow/e2e-aws-single-node e6d8189 link false /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 e6d8189 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack-csi-cinder e6d8189 link false /test e2e-openstack-csi-cinder
ci/prow/okd-scos-e2e-aws-ovn e6d8189 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-disruptive e6d8189 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack e6d8189 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-openstack-csi-manila e6d8189 link false /test e2e-openstack-csi-manila

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 80b82ba into openshift:master Jul 30, 2025
32 of 40 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202507302114.p0.g80b82ba.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202507302114.p0.g80b82ba.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202507302114.p0.g80b82ba.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202507302114.p0.g80b82ba.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants