-
Notifications
You must be signed in to change notification settings - Fork 129
TRT-2097: UPSTREAM: <carry>: Fix up kube test suite definitions for OTE #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-2097: UPSTREAM: <carry>: Fix up kube test suite definitions for OTE #2330
Conversation
For both parallel and serial, the "minimal" suite contains `[Conformance]` in the selector, otherwise we grab them all, except for standardized skipped annotations.
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/lgtm |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
bertinatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-label backports/unvalidated-commits
/approve
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, smg247, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam: This PR was included in a payload test run from openshift/origin#29888
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cefb7d70-46d2-11f0-98cf-d7542a299e08-0 |
|
@stbenjam: This PR was included in a payload test run from openshift/origin#29888
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7493e860-46e9-11f0-8aa0-3d43604da7f0-0 |
|
@stbenjam: This pull request references TRT-2097 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
The original declarations of these suites were incorrect. For both parallel and serial, the "minimal" suite contains
[Conformance]in the selector, otherwise we grab them all, except for standardized excluded tests.This change has no impact until origin uses the CEL expressions defined here.