Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Jun 10, 2025

The original declarations of these suites were incorrect. For both parallel and serial, the "minimal" suite contains [Conformance] in the selector, otherwise we grab them all, except for standardized excluded tests.

This change has no impact until origin uses the CEL expressions defined here.

For both parallel and serial, the "minimal" suite contains
`[Conformance]` in the selector, otherwise we grab them all, except for
standardized skipped annotations.
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 10, 2025
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from benluddy and bertinatto June 10, 2025 15:35
@smg247
Copy link
Member

smg247 commented Jun 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-crun 4ca508f link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-runc 4ca508f link true /test e2e-aws-ovn-runc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label backports/unvalidated-commits
/approve

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 11, 2025
@bertinatto
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, smg247, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

@stbenjam: This PR was included in a payload test run from openshift/origin#29888
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cefb7d70-46d2-11f0-98cf-d7542a299e08-0

@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

@stbenjam: This PR was included in a payload test run from openshift/origin#29888
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7493e860-46e9-11f0-8aa0-3d43604da7f0-0

@stbenjam stbenjam changed the title UPSTREAM: <carry>: Fix up kube test suite definitions for OTE TRT-2097: UPSTREAM: <carry>: Fix up kube test suite definitions for OTE Jun 11, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2025

@stbenjam: This pull request references TRT-2097 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

The original declarations of these suites were incorrect. For both parallel and serial, the "minimal" suite contains [Conformance] in the selector, otherwise we grab them all, except for standardized excluded tests.

This change has no impact until origin uses the CEL expressions defined here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d92880b into openshift:master Jun 11, 2025
25 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202506111942.p0.gd92880b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202506111942.p0.gd92880b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202506111942.p0.gd92880b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202506111942.p0.gd92880b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants