UPSTREAM: <carry>: Initialize testContext before generating ginkgo tests

[jsafrane]

SELinux tests require testContext to be initialized before ginkgo discovers their closures (i.e. before kubeTestsExtension.AddSuite() is called).

Split the testContext initialization in two parts:

initializeCommonTestFramework() files the fields that are either static or can be discovered easily and are needed to generate the tests by ginkgo.

updateTestFrameworkForTests() files the rest, mostly from the cloud provider env. var. and adds fields necessary to actually run the tests.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• e5060da|UPSTREAM: : Initialize testContext before generating ginkgo tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/retest

failed commit on ref "index-image-registry.openshift-image-registry.svc:5000/ci-op-hrr54ccq/pipeline:base-machine-with-rpms@sha256:19c11289983ec4c45033e1a103208016afe08dda20e69ad7f714e10a23d57164": [...] 500 Internal Server Error}

[jsafrane]

I don't like e2e-aws-csi failure, it looks like a regression. Debugging...
/hold

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 030d3ea|Push CSI suite initialization to updateTestFrameworkForTests: does not specify an upstream backport in the commit message
• e5060da|UPSTREAM: : Initialize testContext before generating ginkgo tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 7c0d17a|UPSTREAM: : Push CSI suite initialization to updateTestFrameworkForTests: does not specify an upstream backport in the commit message
• e5060da|UPSTREAM: : Initialize testContext before generating ginkgo tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn-cmd	7c0d17a	link	false	/test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jsafrane]

/hold cancel

[jsafrane]

I can see this was merged during the rebase to 1.33, #2314