-
Notifications
You must be signed in to change notification settings - Fork 128
TRT-2103: Revert "NO-JIRA: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated." #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@xueqzhan: This pull request references TRT-2103 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@xueqzhan: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/lgtm |
|
/retest-required |
c07a842 to
0385d48
Compare
|
@xueqzhan: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
…registration.k8s.io/v1beta1 as deprecated.
0385d48 to
24bf6d5
Compare
|
@xueqzhan: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/skip |
|
/assign @bertinatto |
|
/remove-label backports/unvalidated-commits |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, bertinatto, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@xueqzhan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
c0af259
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
Reverts #2287 tracked by TRT-2103
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
4.20 nightly techpriew serial job failing with test:
[sig-arch][Late] clients should not use APIs that are removed in upcoming releases [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
{ fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:129]: user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicies.v1beta1.admissionregistration.k8s.io 2418 times
user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicybindings.v1beta1.admissionregistration.k8s.io 2418 times
Ginkgo exit error 1: exit with code 1}
Example job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview/1920414382672580608
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
CC: @benluddy @JoelSpeed