Skip to content

Conversation

@xueqzhan
Copy link

@xueqzhan xueqzhan commented May 8, 2025

Reverts #2287 tracked by TRT-2103

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.20 nightly techpriew serial job failing with test:

[sig-arch][Late] clients should not use APIs that are removed in upcoming releases [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
{ fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:129]: user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicies.v1beta1.admissionregistration.k8s.io 2418 times
user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicybindings.v1beta1.admissionregistration.k8s.io 2418 times
Ginkgo exit error 1: exit with code 1}

Example job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview/1920414382672580608

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

CC: @benluddy @JoelSpeed

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2025

@xueqzhan: This pull request references TRT-2103 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Reverts #2287 tracked by TRT-2103

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.20 nightly techpriew serial job failing with test:

[sig-arch][Late] clients should not use APIs that are removed in upcoming releases [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
{ fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:129]: user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicies.v1beta1.admissionregistration.k8s.io 2418 times
user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicybindings.v1beta1.admissionregistration.k8s.io 2418 times
Ginkgo exit error 1: exit with code 1}

Example job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview/1920414382672580608

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

CC: @benluddy @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@xueqzhan: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy
Copy link

benluddy commented May 8, 2025

/lgtm

@openshift-ci openshift-ci bot requested review from jerpeter1 and tkashem May 8, 2025 13:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@xueqzhan
Copy link
Author

xueqzhan commented May 8, 2025

/retest-required

@xueqzhan xueqzhan force-pushed the revert-2287-4.20-admissionregistration-v1beta1-removedrelease branch from c07a842 to 0385d48 Compare May 8, 2025 17:02
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@openshift-ci-robot
Copy link

@xueqzhan: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@xueqzhan xueqzhan force-pushed the revert-2287-4.20-admissionregistration-v1beta1-removedrelease branch from 0385d48 to 24bf6d5 Compare May 8, 2025 17:51
@openshift-ci-robot
Copy link

@xueqzhan: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@xueqzhan
Copy link
Author

xueqzhan commented May 8, 2025

/skip

@benluddy
Copy link

benluddy commented May 8, 2025

/assign @bertinatto

@bertinatto
Copy link
Member

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 8, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2025

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 24bf6d5 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-agnostic-ovn-cmd 24bf6d5 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c0af259 into openshift:master May 8, 2025
20 of 22 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202505082342.p0.gc0af259.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202505082342.p0.gc0af259.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202505082342.p0.gc0af259.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202505082342.p0.gc0af259.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants