OCPBUGS-55632: Fix node expansion on older kubelets

[gnufied]

Where recovery from volume expansion feature is not enabled.

cc @openshift/storage

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-55632, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Where recovery from volume expansion feature is not enabled.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gnufied: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 51d7128|UPSTREAM: 131418/: Check for newer fields when deciding expansion recovery feature status: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-55632, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

• 7d585bc|UPSTREAM: 131418: Check for newer fields when deciding expansion recovery feature status: the upstream PR kubernetes/kubernetes#131418 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[gnufied]

/retest

[dobsonj]

/lgtm

[gnufied]

/retest

[bertinatto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dobsonj, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 83565d5 and 2 for PR HEAD 7d585bc in total

[Phaow]

/retest-required

[gnufied]

So looks like - "tideWaiting for status to be reported — Not mergeable. Job ci/prow/verify-deps has not succeeded."

verify-deps is still required for this PR. I am going to close this PR and open another one.

[bertinatto]

/override ci/prow/verify-deps
This was removed.

[openshift-ci]

@bertinatto: Overrode contexts on behalf of bertinatto: ci/prow/verify-deps

Details

In response to this:

/override ci/prow/verify-deps
This was removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-55632. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Where recovery from volume expansion feature is not enabled.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-55632, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Where recovery from volume expansion feature is not enabled.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-55632, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @chao007

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 83565d5 and 2 for PR HEAD 7d585bc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 83565d5 and 2 for PR HEAD 7d585bc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 83565d5 and 2 for PR HEAD 7d585bc in total

[openshift-ci]

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	7d585bc	link	false	/test verify-deps
ci/prow/e2e-agnostic-ovn-cmd	7d585bc	link	false	/test e2e-agnostic-ovn-cmd
ci/prow/okd-scos-e2e-aws-ovn	7d585bc	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@gnufied: Jira Issue OCPBUGS-55632: All pull requests linked via external trackers have merged:

• openshift/kubernetes#2282

Jira Issue OCPBUGS-55632 has been moved to the MODIFIED state.

Details

In response to this:

Where recovery from volume expansion feature is not enabled.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202505071142.p0.gaa347f0.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202505071142.p0.gaa347f0.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202505071142.p0.gaa347f0.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202505071142.p0.gaa347f0.assembly.stream.el9.
All builds following this will include this PR.

[gnufied]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@gnufied: new pull request created: #2289

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gnufied]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@gnufied: #2282 failed to apply on top of branch "release-4.18":

Applying: UPSTREAM: 131418: Check for newer fields when deciding expansion recovery feature status
Using index info to reconstruct a base tree...
M	pkg/volume/util/operationexecutor/node_expander.go
M	pkg/volume/util/operationexecutor/node_expander_test.go
M	pkg/volume/util/operationexecutor/operation_generator.go
M	pkg/volume/util/operationexecutor/operation_generator_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/volume/util/operationexecutor/operation_generator_test.go
Auto-merging pkg/volume/util/operationexecutor/operation_generator.go
Auto-merging pkg/volume/util/operationexecutor/node_expander_test.go
CONFLICT (content): Merge conflict in pkg/volume/util/operationexecutor/node_expander_test.go
Auto-merging pkg/volume/util/operationexecutor/node_expander.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 UPSTREAM: 131418: Check for newer fields when deciding expansion recovery feature status

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.