Skip to content

OCPBUGS-16922: Remove skip flag for e2e tests related to AdmissionWebhookMatchConditions #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Nov 2, 2023
Merged

OCPBUGS-16922: Remove skip flag for e2e tests related to AdmissionWebhookMatchConditions #1790

openshift-ci merged 1 commit into from
Nov 2, 2023

Conversation

@dinhxuanvu
Copy link
Member

@dinhxuanvu dinhxuanvu commented Oct 31, 2023

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28. It is currently in TechPreviewNoUpgrade feature set in openshift api.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2023

@dinhxuanvu: This pull request references Jira Issue OCPBUGS-16922, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28. It is currently in TechPreviewNoUpgrade feature set in openshift api.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2023

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested a review from wangke19 October 31, 2023 14:33
@dinhxuanvu dinhxuanvu mentioned this pull request Oct 31, 2023
Closed
@openshift-ci openshift-ci bot requested review from deads2k and soltysh October 31, 2023 14:35
@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Oct 31, 2023

/retest

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Oct 31, 2023

@soltysh PTAL. Thanks

@dinhxuanvu
UPSTREAM: <carry>: Disable e2e tests related to AdmissionWebhookMatch…
60171d1 
…Conditions

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28.
It is currently in TechPreviewNoUpgrade feature set in openshift api.

Signed-off-by: Vu Dinh <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 2, 2023

@dinhxuanvu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

soltysh
soltysh approved these changes Nov 2, 2023
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link

soltysh commented Nov 2, 2023

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@soltysh
Copy link

soltysh commented Nov 2, 2023

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 2, 2023

/retest-required

Remaining retests: 0 against base HEAD 6c8041c and 2 for PR HEAD 60171d1 in total

@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2023

@dinhxuanvu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 4cbdd29 into master Nov 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 2, 2023

@dinhxuanvu: Jira Issue OCPBUGS-16922: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16922 has been moved to the MODIFIED state.

Details

In response to this:

The AdmissionWebhookMatchConditions feature is enabled by default on k8s 1.28. It is currently in TechPreviewNoUpgrade feature set in openshift api.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 3, 2023

Fix included in accepted release 4.15.0-0.nightly-2023-11-03-082930

@jlebon jlebon mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dinhxuanvu @openshift-ci-robot @soltysh @openshift-merge-robot