Base kubernetes branch for 1.19-rc.1 (oc-only) #169

damemi · 2020-07-15T20:15:54Z

Previous base #123

Following https://github.com/openshift/enhancements/blob/master/enhancements/oc/upgrade_kubernetes.md

damemi · 2020-07-15T20:55:44Z

/hold
on getting CI for this branch openshift/release#10265

soltysh

All the changes lgtm, I want to see units green and this is good to go.
/lgtm
/approve

soltysh · 2020-07-16T13:15:30Z

/retest

soltysh · 2020-07-16T13:18:22Z

/refresh

droslean · 2020-07-16T13:46:21Z

/refresh
/test all

openshift-ci-robot · 2020-07-16T13:46:38Z

@droslean: No presubmit jobs available for openshift/kubernetes@oc-4.6-kubernetes-1.19-rc.1

Details

In response to this:

/refresh
/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh · 2020-07-16T14:46:50Z

/retest

soltysh · 2020-07-16T15:14:26Z

/test all

openshift-ci-robot · 2020-07-16T15:16:45Z

@soltysh: No presubmit jobs available for openshift/kubernetes@oc-4.6-kubernetes-1.19-rc.1

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

droslean · 2020-07-16T15:17:20Z

Presubmit added manually

droslean · 2020-07-16T15:44:51Z

/test all

openshift-ci-robot · 2020-07-16T15:45:07Z

@droslean: No presubmit jobs available for openshift/kubernetes@oc-4.6-kubernetes-1.19-rc.1

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

damemi · 2020-07-16T17:25:06Z

/retest

soltysh · 2020-07-16T17:29:09Z

/refresh
/test all

openshift-ci-robot · 2020-07-16T17:29:26Z

@soltysh: No presubmit jobs available for openshift/kubernetes@oc-4.6-kubernetes-1.19-rc.1

Details

In response to this:

/refresh
/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh · 2020-07-16T17:33:32Z

/test unit

openshift-ci-robot · 2020-07-16T17:33:50Z

@soltysh: No presubmit jobs available for openshift/kubernetes@oc-4.6-kubernetes-1.19-rc.1

Details

In response to this:

/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hongkailiu · 2020-07-16T18:20:53Z

/test all

soltysh · 2020-07-17T07:57:55Z

/retest

soltysh · 2020-07-17T08:54:47Z

@damemi from what I see here's what the situation looks like these failures are quite repeating and we can safely ignore these packages:

k8s.io/kubernetes/pkg/registry/
k8s.io/apiextensions-apiserver/pkg/registry/
k8s.io/apiserver/pkg/apis/config/validation/
k8s.io/apiserver/pkg/registry/
k8s.io/apiserver/pkg/storage/

This failure is real:

k8s.io/kubectl/pkg/cmd/config

damemi · 2020-07-20T14:04:55Z

/retest

… in tests

damemi · 2020-07-20T15:28:40Z

/retest

damemi · 2020-07-20T16:41:36Z

/retest

damemi · 2020-07-20T18:52:04Z

@soltysh I think something is off with your fix, see https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/169/pull-ci-openshift-kubernetes-oc-4.6-kubernetes-1.19-rc.1-unit/1285253603426045952#1:build-log.txt%3A3852

 === FAIL: vendor/k8s.io/kubectl/pkg/cmd/config TestSetCurrentContext (0.20s)
error: mkdir /.kube: permission denied
FAIL	k8s.io/kubernetes/vendor/k8s.io/kubectl/pkg/cmd/config	0.205s

…ng precedence

damemi · 2020-07-21T19:05:10Z

/retest

damemi · 2020-07-21T21:14:58Z

@soltysh this is green now, want to merge?

soltysh · 2020-07-23T13:07:25Z

@soltysh this is green now, want to merge?

yeah, let's proceed, we'll fix it during another bump, later on.

soltysh

/lgtm

soltysh · 2020-07-23T13:07:48Z

/hold cancel

openshift-ci-robot · 2020-07-23T13:09:11Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: damemi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS
staging/src/k8s.io/api/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damemi mentioned this pull request Jul 15, 2020

[wip] Base 1.19 branch for oc 1.19-rc0 #167

Closed

openshift-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 15, 2020

openshift-ci-robot requested review from smarterclayton and sttts July 15, 2020 20:17

damemi mentioned this pull request Jul 15, 2020

Add openshift-kubernetes-oc-4.6-kubernetes-1.19-rc.1 openshift/release#10265

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020

soltysh approved these changes Jul 16, 2020

View reviewed changes

openshift-ci-robot assigned soltysh Jul 16, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020

soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020

soltysh closed this Jul 16, 2020

soltysh reopened this Jul 16, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020

damemi force-pushed the 1.19-rc1 branch from afd4dad to 01e9d07 Compare July 20, 2020 14:27

soltysh and others added 7 commits July 20, 2020 10:29

UPSTREAM: <carry>: skip irrelevant units and update verify scripts

974f4e0

UPSTREAM: <carry>: kubectl: printers

48b137c

UPSTREAM: <drop>: Update openshift-deps to prebase-1.19-rc.1 branch

8429191

UPSTREAM: <drop>: copy staging dirs

8c1bd73

UPSTREAM: <drop>: hack/update-vendor.sh

240940d

UPSTREAM: <drop>: set minimum go version to 1.13

70fa586

UPSTREAM: 93177: Use temporary directory when creating temporary file…

0e57d4c

… in tests

damemi force-pushed the 1.19-rc1 branch from 01e9d07 to 0e57d4c Compare July 20, 2020 14:29

damemi changed the title ~~Base kubernetes branch for 1.19-rc.1~~ Base kubernetes branch for 1.19-rc.1 (oc-only) Jul 21, 2020

UPSTREAM: 93293: kubeconfig: add explicit path, if specified to loadi…

84250a8

…ng precedence

soltysh approved these changes Jul 23, 2020

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 23, 2020

openshift-merge-robot merged commit a8612c1 into openshift:oc-4.6-kubernetes-1.19-rc.1 Jul 23, 2020

damemi mentioned this pull request Aug 31, 2020

Bump 1.19 oc branch to GA #324

Merged

damemi deleted the 1.19-rc1 branch September 1, 2020 17:37

Base kubernetes branch for 1.19-rc.1 (oc-only) #169

Base kubernetes branch for 1.19-rc.1 (oc-only) #169

Uh oh!

Conversation

damemi commented Jul 15, 2020

Uh oh!

damemi commented Jul 15, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh commented Jul 16, 2020

Uh oh!

soltysh commented Jul 16, 2020

Uh oh!

droslean commented Jul 16, 2020

Uh oh!

openshift-ci-robot commented Jul 16, 2020

Uh oh!

soltysh commented Jul 16, 2020

Uh oh!

soltysh commented Jul 16, 2020

Uh oh!

openshift-ci-robot commented Jul 16, 2020

Uh oh!

droslean commented Jul 16, 2020

Uh oh!

droslean commented Jul 16, 2020

Uh oh!

openshift-ci-robot commented Jul 16, 2020

Uh oh!

damemi commented Jul 16, 2020

Uh oh!

soltysh commented Jul 16, 2020

Uh oh!

openshift-ci-robot commented Jul 16, 2020

Uh oh!

soltysh commented Jul 16, 2020

Uh oh!

openshift-ci-robot commented Jul 16, 2020

Uh oh!

hongkailiu commented Jul 16, 2020

Uh oh!

soltysh commented Jul 17, 2020

Uh oh!

soltysh commented Jul 17, 2020

Uh oh!

damemi commented Jul 20, 2020

Uh oh!

damemi commented Jul 20, 2020

Uh oh!

damemi commented Jul 20, 2020

Uh oh!

damemi commented Jul 20, 2020

Uh oh!

damemi commented Jul 21, 2020

Uh oh!

damemi commented Jul 21, 2020

Uh oh!

soltysh commented Jul 23, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh commented Jul 23, 2020

Uh oh!

openshift-ci-robot commented Jul 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants