Skip to content

Conversation

@benluddy
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 11, 2022
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh November 11, 2022 21:28
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 11, 2022
@benluddy benluddy force-pushed the routev1-host-assignment branch from 7a71785 to 970d042 Compare November 11, 2022 22:05
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy benluddy force-pushed the routev1-host-assignment branch from 970d042 to b00d44d Compare November 11, 2022 23:07
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@benluddy benluddy force-pushed the routev1-host-assignment branch from b00d44d to 6f7367c Compare November 11, 2022 23:43
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy benluddy force-pushed the routev1-host-assignment branch from 6f7367c to 67dceaf Compare November 14, 2022 16:58
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy benluddy force-pushed the routev1-host-assignment branch from 67dceaf to e611960 Compare November 14, 2022 17:02
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy benluddy force-pushed the routev1-host-assignment branch from e611960 to f9ef988 Compare November 14, 2022 18:35
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@benluddy
Copy link
Author

/retest-required

@benluddy
Copy link
Author

/retitle OCPBUGS-3501: UPSTREAM: : Add host assignment plugin for CRD-based routes.

@openshift-ci openshift-ci bot changed the title UPSTREAM: <carry>: Add host assignment plugin for CRD-based routes. OCPBUGS-3501: UPSTREAM: <carry>: Add host assignment plugin for CRD-based routes. Nov 16, 2022
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 16, 2022
@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-3501, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link

tkashem commented Nov 16, 2022

/lgtm

Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@benluddy
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 16, 2022
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 16, 2022
@benluddy benluddy force-pushed the routev1-host-assignment branch from f9ef988 to 453583e Compare November 16, 2022 16:09
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 16, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-ci-robot openshift-ci-robot removed the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Nov 16, 2022
@benluddy
Copy link
Author

/hold cancel

@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2022
@soltysh
Copy link

soltysh commented Nov 16, 2022

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 16, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@tkashem
Copy link

tkashem commented Nov 16, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, soltysh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Author

/retest-required

2 similar comments
@benluddy
Copy link
Author

/retest-required

@benluddy
Copy link
Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2022

@benluddy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 453583e link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 761cfe9 into openshift:master Nov 17, 2022
@openshift-ci-robot
Copy link

@benluddy: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3501 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Copy link
Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@benluddy: #1419 failed to apply on top of branch "release-4.12":

Applying: UPSTREAM: <carry>: Add host assignment plugin for CRD-based routes.
Using index info to reconstruct a base tree...
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 UPSTREAM: <carry>: Add host assignment plugin for CRD-based routes.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Copy link
Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@benluddy: new pull request created: #1427

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants