CNF-5901: admission hook change for workload partition on all clusters #1312

eggfoobar · 2022-07-07T22:55:47Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds the feature of supporting workload partitioning for the whole cluster. Defined in this openshift/enhancements#1213

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

This feature does two major things,

Modifies existing pod mutating webhook to support wide clusters.
Adds admission webhook for nodes to make the infrastructure.status.cpuPartitioning to be authoritative.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP

openshift-ci-robot · 2022-07-07T22:55:56Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

2f0a425|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-07-08T01:41:43Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

6a63cc8|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-10T17:16:23Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

2ee44d6|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
69d6776|feat: cleaned up admission logic: does not specify an upstream backport in the commit message
dbb291c|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-15T18:54:57Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

0638f15|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message
2ee44d6|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
69d6776|feat: cleaned up admission logic: does not specify an upstream backport in the commit message
dbb291c|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-15T21:24:26Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

1452283|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message
2ee44d6|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
69d6776|feat: cleaned up admission logic: does not specify an upstream backport in the commit message
dbb291c|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-18T16:00:23Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

190aa9a|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
81c8647|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message
a52a28d|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message
d0e36f3|feat: cleaned up admission logic: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-26T04:34:42Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

190aa9a|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
81c8647|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message
b049fd4|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message
d0e36f3|feat: cleaned up admission logic: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-26T15:58:47Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

190aa9a|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
81c8647|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message
b7a465f|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message
d0e36f3|feat: cleaned up admission logic: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-26T17:58:58Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

190aa9a|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
81c8647|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message
d0e36f3|feat: cleaned up admission logic: does not specify an upstream backport in the commit message
df161f1|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-08-29T18:46:27Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

190aa9a|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
81c8647|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message
d0e36f3|feat: cleaned up admission logic: does not specify an upstream backport in the commit message
e1dcfd8|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

openshift-ci-robot · 2022-09-07T20:21:01Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

44c6376|tests: updated unit tests to reflect change: does not specify an upstream backport in the commit message
56c4ea9|feat: test out node affinity on managed nodes: does not specify an upstream backport in the commit message
79ae74a|test: custom identifier for partitioning: does not specify an upstream backport in the commit message
92f5f39|feat: added wip workload partition for multinode: does not specify an upstream backport in the commit message
9c1a8ba|feat: cleaned up admission logic: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

eggfoobar · 2022-09-14T12:51:41Z

/hold
Waiting for pr openshift/api#1284

tkashem

some minor comments, but it looks good to me from the api team perspective

/lgtm
/approve

/hold (for @deads2k and @soltysh to have a final look)

openshift-kube-apiserver/admission/autoscaling/managednode/admission.go

openshift-ci-robot · 2023-02-21T17:00:32Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

57df469|UPSTREAM: : bump(openshift/api,openshift/client-go): does not specify an upstream backport in the commit message
9e5c26e|UPSTREAM: : node admission plugin for cpu partitioning: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

soltysh

One minor nit, but otherwise this is good to go.
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

openshift-kube-apiserver/admission/autoscaling/managednode/admission.go

soltysh · 2023-02-22T10:46:51Z

/hold cancel

hack/pin-dependency.sh github.com/openshift/client-go master hack/pin-dependency.sh github.com/openshift/api master hack/update-vendor.sh Signed-off-by: ehila <[email protected]>

The ManagedNode admission plugin makes the Infrastructure.Status.CPUPartitioning field authoritative. This validates that nodes that wish to join the cluster are first configured to properly handle workload pinning For more information see - openshift/enhancements#1213 Signed-off-by: ehila <[email protected]>

openshift-ci-robot · 2023-02-22T15:50:16Z

@eggfoobar: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

04ff509|UPSTREAM: : node admission plugin for cpu partitioning: does not specify an upstream backport in the commit message
78f50d0|UPSTREAM: : bump(openshift/api,openshift/client-go): does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

rphillips · 2023-02-22T16:50:26Z

/retest-required
/lgtm

openshift-ci · 2023-02-22T17:02:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, rphillips, soltysh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [soltysh,tkashem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eggfoobar · 2023-02-23T06:49:56Z

/retest-required

eggfoobar · 2023-02-23T15:16:53Z

/test integration

openshift-ci · 2023-02-23T15:50:11Z

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-cgroupsv2	b69c9fc28f7ba8d37c27d52d9ec75ffb162cfa0b	link	true	`/test e2e-aws-cgroupsv2`
ci/prow/k8s-e2e-gcp	b69c9fc28f7ba8d37c27d52d9ec75ffb162cfa0b	link	true	`/test k8s-e2e-gcp`
ci/prow/e2e-gcp-upgrade	b69c9fc28f7ba8d37c27d52d9ec75ffb162cfa0b	link	true	`/test e2e-gcp-upgrade`
ci/prow/e2e-agnostic-cmd	b69c9fc28f7ba8d37c27d52d9ec75ffb162cfa0b	link	false	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-fips	b69c9fc28f7ba8d37c27d52d9ec75ffb162cfa0b	link	true	`/test e2e-aws-fips`
ci/prow/e2e-aws-crun	b69c9fc28f7ba8d37c27d52d9ec75ffb162cfa0b	link	true	`/test e2e-aws-crun`
ci/prow/e2e-aws-serial	026a8d405d6f6e7afcdd1e095e8cf1fe83bf5acc	link	true	`/test e2e-aws-serial`
ci/prow/e2e-azure-ovn-upgrade	026a8d405d6f6e7afcdd1e095e8cf1fe83bf5acc	link	true	`/test e2e-azure-ovn-upgrade`
ci/prow/k8s-e2e-aws-ovn-serial	`04ff509`	link	false	`/test k8s-e2e-aws-ovn-serial`
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade	`04ff509`	link	false	`/test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-csi	`04ff509`	link	false	`/test e2e-aws-csi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh · 2023-02-23T16:29:15Z

/remove-label backports/unvalidated-commits
/label backports/validated-commits

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 7, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2022

openshift-ci bot requested review from soltysh and sttts July 7, 2022 22:57

eggfoobar force-pushed the wrk-prt-multi-node branch from 2f0a425 to 6a63cc8 Compare July 8, 2022 01:41

eggfoobar force-pushed the wrk-prt-multi-node branch from 6a63cc8 to 69d6776 Compare August 10, 2022 17:16

eggfoobar changed the title ~~WIP: experiment workload partition on non-sno~~ WIP: CNF-5901: experiment workload partition on non-sno Aug 15, 2022

eggfoobar force-pushed the wrk-prt-multi-node branch from 0638f15 to 1452283 Compare August 15, 2022 21:24

eggfoobar force-pushed the wrk-prt-multi-node branch from 1452283 to a52a28d Compare August 18, 2022 16:00

eggfoobar force-pushed the wrk-prt-multi-node branch from a52a28d to b049fd4 Compare August 26, 2022 04:34

eggfoobar force-pushed the wrk-prt-multi-node branch from b049fd4 to b7a465f Compare August 26, 2022 15:58

eggfoobar force-pushed the wrk-prt-multi-node branch from b7a465f to df161f1 Compare August 26, 2022 17:58

eggfoobar force-pushed the wrk-prt-multi-node branch from df161f1 to e1dcfd8 Compare August 29, 2022 18:46

eggfoobar force-pushed the wrk-prt-multi-node branch from e1dcfd8 to 79ae74a Compare September 7, 2022 20:19

openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 7, 2022

eggfoobar changed the title ~~WIP: CNF-5901: experiment workload partition on non-sno~~ CNF-5901: admission hook change for workload partition on all clusters Sep 14, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023

tkashem reviewed Feb 21, 2023

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2023

openshift-ci bot assigned tkashem Feb 21, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023

eggfoobar force-pushed the wrk-prt-multi-node branch from bee3666 to 9e5c26e Compare February 21, 2023 17:00

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023

soltysh approved these changes Feb 22, 2023

View reviewed changes

openshift-kube-apiserver/admission/autoscaling/managednode/admission.go Outdated Show resolved Hide resolved

openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 22, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023

eggfoobar added 2 commits February 22, 2023 10:45

UPSTREAM: <drop>: bump(openshift/api,openshift/client-go)

78f50d0

hack/pin-dependency.sh github.com/openshift/client-go master hack/pin-dependency.sh github.com/openshift/api master hack/update-vendor.sh Signed-off-by: ehila <[email protected]>

eggfoobar force-pushed the wrk-prt-multi-node branch from 9e5c26e to 04ff509 Compare February 22, 2023 15:50

openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Feb 22, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023

openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 23, 2023

openshift-merge-robot merged commit 8923264 into openshift:master Feb 23, 2023

pmtk mentioned this pull request Mar 2, 2023

NO-ISSUE: [MANUAL REBASE] 4.13 amd64:2023-02-27 arm64:2023-02-28 openshift/microshift#1434

Merged

CNF-5901: admission hook change for workload partition on all clusters #1312

CNF-5901: admission hook change for workload partition on all clusters #1312

Uh oh!

Conversation

eggfoobar commented Jul 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 8, 2022

Uh oh!

openshift-ci-robot commented Aug 10, 2022

Uh oh!

openshift-ci-robot commented Aug 15, 2022

Uh oh!

openshift-ci-robot commented Aug 15, 2022

Uh oh!

openshift-ci-robot commented Aug 18, 2022

Uh oh!

openshift-ci-robot commented Aug 26, 2022

Uh oh!

openshift-ci-robot commented Aug 26, 2022

Uh oh!

openshift-ci-robot commented Aug 26, 2022

Uh oh!

openshift-ci-robot commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Sep 7, 2022

Uh oh!

eggfoobar commented Sep 14, 2022

Uh oh!

tkashem left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 21, 2023

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soltysh commented Feb 22, 2023

Uh oh!

openshift-ci-robot commented Feb 22, 2023

Uh oh!

rphillips commented Feb 22, 2023

Uh oh!

openshift-ci bot commented Feb 22, 2023

Uh oh!

eggfoobar commented Feb 23, 2023

Uh oh!

eggfoobar commented Feb 23, 2023

Uh oh!

openshift-ci bot commented Feb 23, 2023

Uh oh!

soltysh commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eggfoobar commented Jul 7, 2022 •

edited

Loading