Revert "UPSTREAM: <carry>: Unskip OCP SDN related tests"

[danwinship]

This reverts commit aba8d20.

Per discussion on slack, this has broken the e2e tests. eg https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi/1508215764547538944

/cc @astoycos
/assign @deads2k

[openshift-ci-robot]

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 755bd8b|Revert "UPSTREAM: : Unskip OCP SDN related tests": does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[deads2k]

When using openshiftSDN, how does a client know that their networkpolicy isn't going to work?

[danwinship]

This is only about test skips. Either (a) the test case is racy (as several other NP tests were) and the failures do not point to any real openshift-sdn bug, or (b) openshift-sdn is buggy, in which case, the user will get buggy behavior.

There are no policies which are being intentionally not implemented correctly.

[astoycos]

Should we add a BZ on the comment here @danwinship so we're tracking the work to fix these with SDN?

[openshift-ci-robot]

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• d032c6e|UPSTREAM: revert: : Unskip OCP SDN related tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[danwinship]

/retest-required

[s-urbaniak]

/retest

[s-urbaniak]

/lgtm

[s-urbaniak]

/retest

[soltysh]

/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, s-urbaniak, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

/hold

This needs the unrevert of the bump to prove it works.

[deads2k]

wrong repo

/hold cancel

[s-urbaniak]

/test e2e-gcp

[openshift-ci]

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.