Skip to content

UPSTREAM: 106454: SQUASH: test/e2e: let e2e tests specify pod security admiss…#1128

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
s-urbaniak:psa-e2e-backport
Mar 10, 2022
Merged

UPSTREAM: 106454: SQUASH: test/e2e: let e2e tests specify pod security admiss…#1128
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
s-urbaniak:psa-e2e-backport

Conversation

@s-urbaniak
Copy link
Copy Markdown

@s-urbaniak s-urbaniak commented Jan 21, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently, e2e tests don't know about PodSecurity Admission. This introduces the possibility to specify namespace labels for tests.

Additionally, it sets a default set of policies for e2e test namespaces bound to restricted.

Finally, it makes a first pass of identified e2e tests which deploy privileged workloads.

@openshift-ci openshift-ci Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 21, 2022
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 21, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 21, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci Bot requested review from marun and mfojtik January 21, 2022 08:05
@s-urbaniak
Copy link
Copy Markdown
Author

s-urbaniak commented Jan 21, 2022

/test unit

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 9, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 9, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@s-urbaniak s-urbaniak mentioned this pull request Feb 9, 2022
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 9, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@s-urbaniak
Copy link
Copy Markdown
Author

s-urbaniak commented Feb 10, 2022

/test required

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 10, 2022

@s-urbaniak: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test artifacts
  • /test configmap-scale
  • /test e2e-aws-downgrade
  • /test e2e-aws-fips
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-cgroupsv2
  • /test e2e-aws-crun
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-single-node
  • /test e2e-azure
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-csi-cinder
  • /test e2e-openstack-csi-manila
  • /test e2e-vsphere
  • /test k8s-e2e-aws
  • /test k8s-e2e-aws-serial
  • /test k8s-e2e-gcp-five-control-plane-replicas

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kubernetes-master-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-kubernetes-master-e2e-aws-crun
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits
Details

In response to this:

/test required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Copy Markdown
Author

s-urbaniak commented Feb 10, 2022

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 23, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@deads2k
Copy link
Copy Markdown

deads2k commented Mar 1, 2022

need to get the commit name updated to match the PR number. I think this is important to pick early so we can make rapid progress on the pod security admission

/approve
/assign @stlaz

@stlaz owns lgtm.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@s-urbaniak s-urbaniak changed the title UPSTREAM: 106454: test/e2e: let e2e tests specify pod security admiss… UPSTREAM: 106454: SQUASH: test/e2e: let e2e tests specify pod security admiss… Mar 10, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 10, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@s-urbaniak
Copy link
Copy Markdown
Author

s-urbaniak commented Mar 10, 2022

need to get the commit name updated to match the PR number.

done

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 10, 2022

@s-urbaniak: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stlaz
Copy link
Copy Markdown

stlaz commented Mar 10, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Mar 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@soltysh soltysh added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Mar 10, 2022
@s-urbaniak
Copy link
Copy Markdown
Author

s-urbaniak commented Mar 10, 2022

/test e2e-aws-serial

@s-urbaniak
Copy link
Copy Markdown
Author

s-urbaniak commented Mar 10, 2022

/test e2e-gcp

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Mar 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 10, 2022

@s-urbaniak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi 542e1f8 link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Mar 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 65ef2f4 into openshift:master Mar 10, 2022
@s-urbaniak s-urbaniak deleted the psa-e2e-backport branch March 10, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marun marun Awaiting requested review from marun

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@stlaz stlaz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@s-urbaniak @openshift-ci-robot @deads2k @stlaz @openshift-bot @soltysh @openshift-merge-robot