Bug 2033751: fix -rt builds and copy extensions into resulting image#1106
Conversation
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.10 ci blocking |
|
@rphillips: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4313d220-72f1-11ec-973a-65494dc997d4-0 trigger 4 jobs of type informing for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4313d220-72f1-11ec-973a-65494dc997d4-1 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4313d220-72f1-11ec-973a-65494dc997d4-2 trigger 44 jobs of type informing for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4313d220-72f1-11ec-973a-65494dc997d4-3 |
6895835 to
4ae0671
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
4ae0671 to
d9a58ca
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.10 ci blocking |
|
@rphillips: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14def7f0-72fa-11ec-9991-7255c7bef4bf-0 trigger 4 jobs of type informing for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14def7f0-72fa-11ec-9991-7255c7bef4bf-1 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14def7f0-72fa-11ec-9991-7255c7bef4bf-2 trigger 44 jobs of type informing for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14def7f0-72fa-11ec-9991-7255c7bef4bf-3 |
d9a58ca to
e16f381
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
e16f381 to
56bfe24
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.10 ci blocking |
|
@rphillips: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bfdab3c0-7303-11ec-95dc-f349429052f9-0 trigger 4 jobs of type informing for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bfdab3c0-7303-11ec-95dc-f349429052f9-1 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bfdab3c0-7303-11ec-95dc-f349429052f9-2 trigger 44 jobs of type informing for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bfdab3c0-7303-11ec-95dc-f349429052f9-3 |
openshift-hack/images/os/Dockerfile
Outdated
There was a problem hiding this comment.
I think this is still wrong though; it should be (as I said above) COPY --from=build /extensions/ /extensions/. The RPM extensions are in /extensions.
(Confusingly, there is /srv/repo/extensions, but that's a completely separate thing that we're not using)
56bfe24 to
ad2d528
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.10 ci blocking |
|
@rphillips: trigger 5 jobs of type blocking for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a5ce6e10-7306-11ec-8402-5dc49344f916-0 trigger 4 jobs of type informing for the ci release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a5ce6e10-7306-11ec-8402-5dc49344f916-1 trigger 7 jobs of type blocking for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a5ce6e10-7306-11ec-8402-5dc49344f916-2 trigger 44 jobs of type informing for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a5ce6e10-7306-11ec-8402-5dc49344f916-3 |
ad2d528 to
c283c5e
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
c283c5e to
4627421
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.10 nightly informing |
|
@rphillips: trigger 44 jobs of type informing for the nightly release of OCP 4.10
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/95781da0-7314-11ec-9a6e-9d9d0c440e8a-0 |
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
1 similar comment
|
/retest |
|
This is close. The masters are coming up and the workers are pivoting into the rt kernel... There is an issue on boot after the pivot with xfs... Pinged @miabbott about it on slack. |
f2b0e68 to
9b19ca9
Compare
|
@rphillips: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
| @@ -1,26 +1,18 @@ | |||
| # fedora:29 is an image built within the release scripts: | |||
| # https://github.com/openshift/release/blob/b45a09d248b8cdb8fe3bf5f3cfa0b4fee57d04c8/ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.10.yaml#L63-L65 | |||
There was a problem hiding this comment.
That's wrong, that's only reflecting the mapping, we can change it here and we should change it. I can followup on that, and then we'll update release repo as well.
| FROM fedora:29 AS build | ||
|
|
||
| # the registry is defined here: | ||
| # https://github.com/openshift/release/blob/b45a09d248b8cdb8fe3bf5f3cfa0b4fee57d04c8/ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.10.yaml#L68 |
There was a problem hiding this comment.
Same comment as above, can be changed.
| LABEL io.openshift.build.version-display-names="machine-os=rhcos image for testing openshift kubernetes kubelet only- if you see this outside of PR runs for openshift kubernetes- you found an urgent blocker bug" \ | ||
| io.openshift.build.versions="machine-os=1.2.3-testing-if-you-see-this-outside-of-PR-runs-for-openshift-kubernetes-you-found-an-urgent-blocker-bug" | ||
| LABEL io.openshift.build.version-display-names="machine-os=rhcos image for testing openshift kubernetes kubelet only- if you see this outside of PR runs for openshift kubernetes- you found an urgent blocker bug" | ||
| LABEL io.openshift.build.versions="machine-os=1.2.3-testing-if-you-see-this-outside-of-PR-runs-for-openshift-kubernetes-you-found-an-urgent-blocker-bug" |
There was a problem hiding this comment.
Don't change it, the idea was to have the least amount of layers as possible, which results in smaller image.
|
/test k8s-e2e-gcp-serial |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rphillips: This pull request references Bugzilla bug 2033751, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-label backports/unvalidated-commits |
|
serial failure is unrelated, tested after the main kube bump. We need the builds. merging. |
|
/override ci/prow/k8s-e2e-gcp-serial |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/k8s-e2e-gcp-serial DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/refresh |
|
@rphillips: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2033751 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rphillips: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Extensions from CoreOS were not included in the docker image. Copy those into the resulting image.