This repository was archived by the owner on Dec 1, 2022. It is now read-only.
[CP][0.23]Add root ca for Controller HA test with https (#11471)#836
Merged
openshift-merge-robot merged 6 commits intoopenshift:release-v0.23.1from Jul 1, 2021
Merged
Conversation
This patch adds `test.AddRootCAtoTransport` for prober in TestControllerHA.
openshift-ci
bot
added
the
area/test-and-release
Author
|
/hold Test passed but pin to release-1.16 is wrong. I think I should update release label. |
openshift-ci
bot
added
the
do-not-merge/hold
This reverts commit d2be74a.
* Remove config/domainmapping * Add 0.23 label
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
test.AddRootCAtoTransportfor prober in TestControllerHA.It cherr-picked from upstream's knative@7253895 and changes test code.
It was backported for 0.22 #815 but slipped from backport for 0.23.