Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

WIP: try to kick net-istio e2e#751

Closed
nak3 wants to merge 16 commits intoopenshift:release-nextfrom
nak3:add-net-istio-ci
Closed

WIP: try to kick net-istio e2e#751
nak3 wants to merge 16 commits intoopenshift:release-nextfrom
nak3:add-net-istio-ci

Conversation

@nak3
Copy link

@nak3 nak3 commented Apr 30, 2021

e2e cannot enable sidecar injection so mTLS is also not strict but to confirm plain net-istio works fine.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign skonto after the PR has been reviewed.
You can assign the PR to them by writing /assign @skonto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2021
@nak3 nak3 force-pushed the add-net-istio-ci branch from c7b6b9c to 1caa901 Compare May 2, 2021 01:02
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2021
@nak3 nak3 force-pushed the add-net-istio-ci branch from 7f84beb to c41994c Compare May 2, 2021 07:22
@nak3 nak3 force-pushed the add-net-istio-ci branch from 9f5b2a6 to 0d80ad6 Compare May 3, 2021 01:23
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@alanfx alanfx force-pushed the release-next branch 2 times, most recently from e891a66 to 380e0fd Compare May 6, 2021 00:34
@nak3 nak3 force-pushed the add-net-istio-ci branch from 0d80ad6 to 84c0331 Compare May 6, 2021 04:28
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2021
@nak3
Copy link
Author

nak3 commented May 6, 2021

There are some failures but almost all of them could be addressed:

  • GRPC ... Our gRPC test does not use ResolvableDomain to test Kourier's LB endpoint directory. Istio is ClusterIP so it does not work.
  • ServiceToService (including websocket) tests ... It enables sidecar annotation as below and hit the Istio bug OSSM-449

https://github.com/knative/serving/blob/d43641480df38005e5726864a7f271ef0cb70899/test/e2e/service_to_service_test.go#L123

@nak3 nak3 force-pushed the add-net-istio-ci branch from 84cf0c2 to 44cb02b Compare May 7, 2021 01:23
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign skonto after the PR has been reviewed.
You can assign the PR to them by writing /assign @skonto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Author

nak3 commented May 7, 2021

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2021
@nak3 nak3 force-pushed the add-net-istio-ci branch from 6b31cbe to 40400fd Compare May 8, 2021 05:22
@openshift-ci openshift-ci bot added area/test-and-release Issues or PRs related to test and release and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 8, 2021
@nak3
Copy link
Author

nak3 commented May 9, 2021

websocket seems not work with redirect.

^[[36mINFO^[[0m[2021-05-08T15:56:40Z]     websocket.go:79: HTTP connection failed: websocket: bad handshake. Response=&{Status:302 Found StatusCode:302 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Cache-Control:[no-cache] Content-Length:[0] Location:[https://green-web-socket-blue-gree-iigkfswf-serving-tests.apps.ci-op-9m7jbrrq-7d3ef.origin-ci-int-aws.dev.rhcloud.com/]] Body:{Reader:0xc00083a3c0} ContentLength:0 TransferEncoding:[] Close:false Uncompressed:false Trailer:map[] Request:0xc00118c300 TLS:<nil>}. ResponseBody=""

@alanfx alanfx force-pushed the release-next branch 4 times, most recently from ff60471 to 05054fa Compare May 26, 2021 11:45
@nak3
Copy link
Author

nak3 commented Jun 16, 2021

/test 4.6-e2e-aws-ocp-46

1 similar comment
@nak3
Copy link
Author

nak3 commented Jun 16, 2021

/test 4.6-e2e-aws-ocp-46

@nak3
Copy link
Author

nak3 commented Jun 16, 2021

@nak3
Copy link
Author

nak3 commented Jun 17, 2021

/test 4.6-e2e-aws-ocp-46

@nak3
Copy link
Author

nak3 commented Jun 17, 2021

/retest

VPC issue 😿

@nak3
Copy link
Author

nak3 commented Jun 19, 2021

/test 4.7-e2e-aws-ocp-47

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2021

@nak3: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/4.7-e2e-aws-ocp-47 7c33ed3 link /test 4.7-e2e-aws-ocp-47

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Author

nak3 commented Jun 21, 2021

Hmm... not sure why 4.6 passed and running the test on my local 4.7 passed but the 4.7 CI does not pass.
Closing for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/test-and-release Issues or PRs related to test and release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants