Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: enable hashicorp vault secret tests #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkyros
Copy link

@jkyros jkyros commented Jun 21, 2024

The tests aren't secret, the tests are for the secret provider. 😄

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2024
@openshift-ci openshift-ci bot requested a review from joelsmith June 21, 2024 14:53
Copy link

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@joelsmith
Copy link

Shhhhh! Don't tell people about your secret tests!

@jkyros
Copy link
Author

jkyros commented Aug 6, 2024

just in case this magically fixed itself after our rebase...
/retest-required

Copy link

openshift-ci bot commented Aug 6, 2024

@jkyros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/keda-e2e-aws-ovn 1620d5c link true /test keda-e2e-aws-ovn
ci/prow/cma-verify-history 1620d5c link true /test cma-verify-history

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants