Account for different upstream/downstream ipxe filenames

[juliakreger]

No description provided.

[derekhiggins]

I don't see prepare-ipxe.sh, did you forget to add it?
I'm also wondering what was wrong with the downstream only version (changed here #9), I didn't think openshift ci would be looking at this .ocp file)

[derekhiggins]

Does there need to be two commits here?

[dtantsur]

Shouldn't we do it upstream? One day CentOS 8 will become a thing..

[elfosardo]

@dtantsur we should, actually we should keep upstream and downstream as close as possible
until centos8 is not here though, it looks hard, unless we could use ubi8

[dtantsur]

If we can confirm this code works with RHEL 8, we know it will work for CentOS 8, no?

[derekhiggins]

Does there need to be two commits here?

Now there is 3 commits, can we squash them into one?

[juliakreger]

@dtantsur only once the downstream image sync occurs, and once merged it will be an email tomorrow.

[juliakreger]

@derekhiggins Can we just squash with merge buttin in the github ui?

[juliakreger]

@elfosardo We are using ubi8. The downstream team has no idea why this is happening :\

[juliakreger]

FYI, the OpenShift nightly build failed because of this, so it would be good to move this forward ASAP as they are wanting to re-trigger the nightly builds.

[dtantsur]

/lgtm

Please consider my nits when creating an upstream version (and let's make sure we have an upstream version when we prove this working).

[dtantsur]

nit: please update it to COPY when implementing upstream

[dtantsur]

nit: mkdir -p

[derekhiggins]

@derekhiggins Can we just squash with merge buttin in the github ui?

yup, have never that before but works for me

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, dtantsur, elfosardo, juliakreger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [derekhiggins,dtantsur,elfosardo,juliakreger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment