AGENT-1303: Run agent-register-infraenv in interactive mode#9960
AGENT-1303: Run agent-register-infraenv in interactive mode#9960openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request references AGENT-1303 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
| @@ -4,7 +4,6 @@ Wants=network-online.target assisted-service.service | |||
| PartOf=assisted-service-pod.service | |||
| After=network-online.target assisted-service.service agent-register-cluster.service agent-import-cluster.service | |||
There was a problem hiding this comment.
Is it not like that the agent-register-infraenv.service should be the one that starts as soon as assisted service is up?
There was a problem hiding this comment.
And, agent-register-cluster.service agent-import-cluster.service should be after agent-register-infraenv.service
There was a problem hiding this comment.
For the regular ABI flow we bind the InfraEnv to the Cluster at the time the InfraEnv is created, which means the Cluster must be created first.
For the late-binding flow we can create the InfraEnv without creating a Cluster. (That's what this change enables.)
Perhaps in the future we will use late-binding everywhere, but that would require other changes to bind the hosts to the Cluster at a later stage that I am not proposing right now.
There was a problem hiding this comment.
I think this config will work fine, as agent-start-ui will pull-in the agent-register-infraenv svc when executed (so when the sentinel file /etc/assisted/interactive-ui will be present).
The agent-register-cluster will keep being skipped in such case
|
@zaneb The dependent PR is merged. Can this be opened and merged? |
|
/approve |
openshift-ci
bot
added
the
approved
| @@ -4,7 +4,6 @@ Wants=network-online.target assisted-service.service | |||
| PartOf=assisted-service-pod.service | |||
| After=network-online.target assisted-service.service agent-register-cluster.service agent-import-cluster.service | |||
There was a problem hiding this comment.
I think this config will work fine, as agent-start-ui will pull-in the agent-register-infraenv svc when executed (so when the sentinel file /etc/assisted/interactive-ui will be present).
The agent-register-cluster will keep being skipped in such case
|
/hold (if you want land the UI pr first) |
openshift-ci
bot
added
the
do-not-merge/hold
Register the InfraEnv (using late binding) when the interactive GUI is enabled.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
openshift-assisted/assisted-installer-ui#3259 has merged so in theory it is safe to merge this now, and possibly even desirable because the UI has been broken since openshift-assisted/assisted-installer-ui#3244 /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest-required |
|
/test ci/prow/e2e-agent-compact-ipv4-appliance-diskimage |
|
@pawanpinjarkar: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-appliance-diskimage |
|
@pawanpinjarkar: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-agent-compact-ipv4-appliance-diskimage |
|
/verified bypass Late binding changes from this PR and openshift/assisted-service#8059 were tested manually via late binding POC |
openshift-ci-robot
added
the
verified
|
@pawanpinjarkar: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/test e2e-agent-compact-ipv4 |
|
/test ci/prow/e2e-agent-compact-ipv4-appliance-diskimage |
|
@zaneb: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-agent-compact-ipv4-appliance-diskimage |
zaneb
removed
the
verified
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by ci/prow/e2e-agent-compact-ipv4-appliance-diskimage, @pawanpinjarkar |
openshift-ci-robot
added
the
verified
|
@zaneb: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 4b8f8de
into
openshift:main
4 participants
Register the InfraEnv (using late binding) when the interactive GUI is enabled.
Depends on openshift/assisted-service#8059