CORS-4078: disable rate limiter for AWS SDK v2#9958
Conversation
The SDK v2 introduces a new client-side rate-limiting mechanism in the standard retry[0][1]. The default settings are not a good fit for the installer, especially the destroy code. Until we figure out a good settings, we disable it to align with SDK v1 behavior. Reference: [0] https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/configure-retries-timeouts.html [1] aws/aws-sdk-go-v2#1665 (comment)
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4078 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "4.20.0" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cc @barbacbd |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
/verified by e2e-aws-ovn |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This is specifically to pick up openshift/installer#9958 which switches off a client-side rate limiter introduced in AWS SDK v2. This rate limiter may have been / probably would eventually be DoSing deprovisions in big environments.
This is specifically to pick up openshift/installer#9958 which switches off a client-side rate limiter introduced in AWS SDK v2. This rate limiter may have been / probably would eventually be DoSing deprovisions in big environments.
This is specifically to pick up openshift/installer#9958 which switches off a client-side rate limiter introduced in AWS SDK v2. This rate limiter may have been / probably would eventually be DoSing deprovisions in big environments.
4 participants
The SDK v2 introduces a new client-side rate-limiting mechanism in the standard retry[0][1]. The default settings are not a good fit for the installer, especially the destroy code.
Until we figure out a good settings, we disable it to align with SDK v1 behavior.
Reference:
[0] https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/configure-retries-timeouts.html
[1] aws/aws-sdk-go-v2#1665 (comment)