Skip to content

AGENT-1269: Update references to agent-installer-ui image#9868

Closed
rwsu wants to merge 2 commits intoopenshift:mainfrom
rwsu:AGENT-1269
Closed

AGENT-1269: Update references to agent-installer-ui image#9868
rwsu wants to merge 2 commits intoopenshift:mainfrom
rwsu:AGENT-1269

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Aug 5, 2025

After the agent-installer-ui image is built downstream, we can update get-container-images.sh to fetch it from the release image.

The temporary code in agent-extract-tui.service to copy the UI bits can also be removed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2025

@rwsu: This pull request references AGENT-1269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

After the agent-installer-ui image is built downstream, we can update get-container-images.sh to fetch it from the release image.

The temporary code in agent-extract-tui.service to copy the UI bits can also be removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 6, 2025

/hold

Until the image is included in the release.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
After the agent-installer-ui image is built downstream, we can
update get-container-images.sh to fetch it from the release image.

The temporary code in agent-extract-tui.service to copy the UI
bits can also be removed.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar
Copy link
Contributor

Tracked via #9995

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-multi-network-techpreview ce8b8e6 link false /test e2e-vsphere-ovn-multi-network-techpreview
ci/prow/e2e-vsphere-host-groups-ovn-techpreview ce8b8e6 link false /test e2e-vsphere-host-groups-ovn-techpreview
ci/prow/e2e-vsphere-externallb-ovn 8009120 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-agent-5control-ipv4 f499961 link false /test e2e-agent-5control-ipv4
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage f499961 link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/e2e-agent-compact-ipv4-none-platform f499961 link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/e2e-agent-ha-dualstack f499961 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-sno-ipv4-pxe f499961 link false /test e2e-agent-sno-ipv4-pxe
ci/prow/e2e-agent-sno-ipv6 f499961 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-agent-4control-ipv4 f499961 link false /test e2e-agent-4control-ipv4
ci/prow/e2e-agent-compact-ipv4-iso-no-registry f499961 link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/okd-scos-e2e-aws-ovn f499961 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-agent-compact-ipv4 f499961 link true /test e2e-agent-compact-ipv4
ci/prow/artifacts-images f499961 link true /test artifacts-images
ci/prow/e2e-agent-compact-ipv6-minimaliso f499961 link false /test e2e-agent-compact-ipv6-minimaliso

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rwsu
Copy link
Contributor Author

rwsu commented Oct 13, 2025

Replaced by #9995

@rwsu rwsu closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants