Skip to content

OCPBUGS-56876: gather: collect logs & analyze node-image-pull #9761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickdillon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-56876: gather: collect logs & analyze node-image-pull #9761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c0261
gather: collect logs & analyze node-image-pull
patrickdillon May 29, 2025
250b7ff
gather: add node-image-pull service
patrickdillon Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/data/bootstrap/files/usr/local/bin/installer-gather.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ done
echo "Gathering bootstrap journals ..."
mkdir -p "${ARTIFACTS}/bootstrap/journals"
for service in approve-csr bootkube crio crio-configure image-customization ironic ironic-dnsmasq ironic-httpd ironic-ramdisk-logs \
kubelet master-bmh-update metal3-baremetal-operator release-image release-image-download sssd
kubelet master-bmh-update metal3-baremetal-operator release-image release-image-download sssd node-image-pull
do
journalctl --boot --no-pager --output=short --unit="${service}" > "${ARTIFACTS}/bootstrap/journals/${service}.log"
done
Expand Down
1 change: 1 addition & 0 deletions pkg/gather/service/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func analyzeGatherBundle(bundleFile io.Reader) error {
check func(analysis) bool
optional bool
}{
{name: "node-image-pull", check: checkReleaseImageDownload, optional: false},
Copy link
Member

@tthvo tthvo May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about adding unit tests case for node-image-pull in:

installer/pkg/gather/service/analyze_test.go

Line 48 in 88ba667

func TestAnalyzeGatherBundle(t *testing.T) {

But the service release-image and node-image-pull are handled the same way. Let's just rename test cases to node-image-pull instead to avoid dups + reflect the new "actually being used" service?

{name: "release-image", check: checkReleaseImageDownload, optional: false},
{name: "bootkube", check: checkBootkubeService, optional: false},
}
Expand Down