Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-52659: [release-4.18] CORS-3825: pkg/infrastructure/azure: support nvme #9545

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

OCPBUGS-52659: [release-4.18] CORS-3825: pkg/infrastructure/azure: support nvme #9545

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9232

/assign patrickdillon

@patrickdillon
pkg/infrastructure/azure: support nvme
12c9b2a 
Updates the installer-generated image definition to indicate support
for NVME (and SCSI) disk controllers. Without this feature on the
image definition, certain VM families will fail to provision with
a message such as:

The VM size 'Standard_D8ds_v6' cannot boot with OS image or disk.
Please check that disk controller types supported by the OS image or
disk is one of the supported disk controller types for the VM size
'Standard_D8ds_v6'.

With the change in this commit, the VM will successfully provision.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 7, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORS-3825

In response to this:

This is an automated cherry-pick of #9232

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie and patrickdillon March 7, 2025 19:53
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhixson74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor

/jira cherry-pick OCPBUGS-52658

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2025 •
edited by openshift-ci bot
Loading

@patrickdillon: Jira Issue OCPBUGS-52658 has been cloned as Jira Issue OCPBUGS-52659. Will retitle bug to link to clone.
/retitle OCPBUGS-52659: [release-4.18] CORS-3825: pkg/infrastructure/azure: support nvme

In response to this:

/jira cherry-pick OCPBUGS-52658

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] CORS-3825: pkg/infrastructure/azure: support nvme OCPBUGS-52659: [release-4.18] CORS-3825: pkg/infrastructure/azure: support nvme Mar 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-52659, which is invalid:

  • expected dependent Jira Issue OCPBUGS-52658 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-52658 to target a version in 4.19.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9232

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 8, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 12c9b2a link false /test okd-scos-e2e-aws-ovn
ci/prow/artifacts-images 12c9b2a link true /test artifacts-images
ci/prow/e2e-azurestack 12c9b2a link false /test e2e-azurestack
ci/prow/e2e-azure-ovn-shared-vpc 12c9b2a link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-aws-ovn 12c9b2a link true /test e2e-aws-ovn
ci/prow/okd-scos-images 12c9b2a link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @patrickdillon