Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-52356: IBMCloud: Fix CAPI endpoint overrides #9540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjschaef
Copy link
Member

@cjschaef cjschaef commented Mar 6, 2025

Fix the endpoint override support for IBM Cloud CAPI and the Ignition URL for bootstrap node during CAPI deployment.

Related: https://issues.redhat.com/browse/OCPBUGS-52356

Fix the endpoint override support for IBM Cloud CAPI and
the Ignition URL for bootstrap node during CAPI deployment.

Related: https://issues.redhat.com/browse/OCPBUGS-52356
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2025
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-52356, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix the endpoint override support for IBM Cloud CAPI and the Ignition URL for bootstrap node during CAPI deployment.

Related: https://issues.redhat.com/browse/OCPBUGS-52356

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and rvanderp3 March 6, 2025 23:12
@MayXuQQ
Copy link
Contributor

MayXuQQ commented Mar 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: This pull request references Jira Issue OCPBUGS-52356, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Mar 7, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: This pull request references Jira Issue OCPBUGS-52356, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ March 7, 2025 08:10
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MayXuQQ
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjschaef
Copy link
Member Author

cjschaef commented Mar 7, 2025

/test altinfra-e2e-ibmcloud-capi-ovn

Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-externallb-ovn 0686160 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-vsphere-ovn-multi-network 0686160 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-azure-ovn-resourcegroup 0686160 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-ibmcloud-ovn 0686160 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-aws-ovn 0686160 link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 0686160 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants