-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-51209: Changed kernelFileType name from kernel.img to vmlinuz for s390x #9533
base: main
Are you sure you want to change the base?
Conversation
…mlinuz for s390x instead of kernel.img Signed-off-by: DAMISETTI-VEERABHADRARAO <[email protected]>
Skipping CI for Draft Pull Request. |
@veera-damisetti: This pull request references Jira Issue OCPBUGS-51209, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…atement , to avoid singleCaseSwitch Signed-off-by: DAMISETTI-VEERABHADRARAO <[email protected]>
/jira refresh |
@veera-damisetti: This pull request references Jira Issue OCPBUGS-51209, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@veera-damisetti: This pull request references Jira Issue OCPBUGS-51209, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-agent-4control-ipv4 |
/test e2e-agent-5control-ipv4 |
/test e2e-vsphere-static-ovn |
/test e2e-vsphere-externallb-ovn |
/test e2e-vsphere-ovn-multi-network |
1 similar comment
/test e2e-vsphere-ovn-multi-network |
/test okd-scos-images |
/test okd-scos-e2e-aws-ovn |
/test e2e-agent-4control-ipv4 |
/test e2e-agent-5control-ipv4 |
/test okd-scos-e2e-aws-ovn |
/test e2e-agent-4control-ipv4 |
/test okd-scos-e2e-aws-ovn |
case arch.RpmArch(types.ArchitectureS390X): | ||
|
||
kernelFileType = "kernel.img" | ||
kernelFileType = "vmlinuz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just remove this variable now that it only ever has one value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zaneb for the review and inputs .
yeah we can remove this variable now as it has "vmlinuz" always.
…able, as it has vmlinuz always Signed-off-by: DAMISETTI-VEERABHADRARAO <[email protected]>
Signed-off-by: DAMISETTI-VEERABHADRARAO <[email protected]>
/retest-required |
1 similar comment
/retest-required |
/test e2e-azure-ovn-resourcegroup |
/test e2e-vsphere-externallb-ovn |
/test e2e-vshepere-ovn-multi-network |
@veera-damisetti: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-vshphere-ovn-multi-network |
@veera-damisetti: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-vsphere-ovn-multi-network |
/test e2e-agent-compact-ipv4-appliance-diskimage |
@zaneb |
/test e2e-agent-compact-ipv4-appliance-diskimage |
2 similar comments
/test e2e-agent-compact-ipv4-appliance-diskimage |
/test e2e-agent-compact-ipv4-appliance-diskimage |
@veera-damisetti: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Changed kernelFileType name from kernel.img to vmlinuz for s390x
As with rhcos 9.6 there will be no kernel.img in the ISO images under /images/pxeboot and to maintain the same name across all architectures , renaming kernelFiletype from kernel.img to vmlinuz for s390x as well.