OCPBUGS-6271: Adding VIPs Validation for agent based vsphere installation #9532
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@sunku5494: This pull request references Jira Issue OCPBUGS-6271, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sunku5494
changed the title
|
@sunku5494: This pull request references Jira Issue OCPBUGS-6271, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @bfournie |
There was a problem hiding this comment.
Hi, I have some small comments but overall, it's LGTM.
@sunku5494 Would it be okay for you to include some contexts/messages in the commit? You can just take the descriptions in the jira ticket OCPBUGS-6271.
| @@ -108,7 +112,7 @@ platform: | |||
| pullSecret: "{\"auths\":{\"example.com\":{\"auth\":\"c3VwZXItc2VjcmV0Cg==\"}}}" | |||
| `, | |||
| expectedFound: false, | |||
| expectedError: `invalid install-config configuration: [platform.vsphere.ingressVIPs: Required value: must specify VIP for ingress, when VIP for API is set, Platform.VSphere.failureDomains.topology.folder: Required value: must specify a folder for agent-based installs]`, | |||
| expectedError: `invalid install-config configuration: [platform.vsphere.ingressVIPs: Required value: must specify VIP for ingress, when VIP for API is set, platform.vsphere.ingressVIPs: Required value: must specify at least one VIP for the Ingress, Platform.VSphere.failureDomains.topology.folder: Required value: must specify a folder for agent-based installs]`, | |||
There was a problem hiding this comment.
I think there are a couple more test cases (i.e. taken from potential returned error) to cover here for vSphere:
apiVIP missingboth apiVIP and ingressVIP missinginvalid value (not an IP) for apiVIP and ingressVIPwhen NOT using user-managed loadbalancer, apiVIP must be different than ingressVIP.when NOT using user-managed loadbalancer, apiVIP and ingressVIP must be in the machine network.If 2 API/Ingress VIPs are given, one must be ipv4 and other must be ipv6API/Ingress VIP must be of the same IP family with machine network's primary IP Family for dual-stack IPv4/IPv6
I don't think these are really needed to fix the bug but it would be good to have these cases in a follow-up later 😄
Co-authored-by: Thuan Vo <[email protected]>
|
/retest |
|
@sunku5494: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.