Skip to content

Conversation

@giladravid16
Copy link
Contributor

If arbiter is set in the install config, then we want to set it's default values.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2025

@giladravid16: This pull request references OCPEDGE-1635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

If arbiter is set in the install config, then we want to set it's default values.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rna-afk and sadasu March 3, 2025 12:06
@giladravid16
Copy link
Contributor Author

/cc @patrickdillon

I saw that you approved #9159, can you also approve this?

@openshift-ci openshift-ci bot requested a review from patrickdillon March 3, 2025 13:50
@giladravid16
Copy link
Contributor Author

/retest

@patrickdillon
Copy link
Contributor

/approve
cc @eggfoobar

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@eggfoobar
Copy link
Contributor

Thanks for the help @giladravid16! Just a small suggestion from me.

@giladravid16
Copy link
Contributor Author

/retest

1 similar comment
@giladravid16
Copy link
Contributor Author

/retest

@eggfoobar
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
@giladravid16
Copy link
Contributor Author

/retest-required

@giladravid16
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

@giladravid16: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d7ee1bf into openshift:main Mar 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants